From: Christian Marangi <ansuelsmth@gmail.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: linux-mediatek@lists.infradead.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mmc@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Wenbin Mei <wenbin.mei@mediatek.com>,
Conor Dooley <conor+dt@kernel.org>,
upstream@airoha.com, Chaotian Jing <chaotian.jing@mediatek.com>
Subject: Re: [PATCH 1/2] dt-bindings: mmc: mtk-sd: Add eMMC for AN7581
Date: Wed, 15 Jan 2025 09:39:34 +0100 [thread overview]
Message-ID: <67877449.df0a0220.cdd29.8807@mx.google.com> (raw)
In-Reply-To: <173693027082.3240418.16772447316188600820.robh@kernel.org>
On Wed, Jan 15, 2025 at 02:37:50AM -0600, Rob Herring (Arm) wrote:
>
> On Wed, 15 Jan 2025 08:29:50 +0100, Christian Marangi wrote:
> > Document eMMC compatible for AN7581. This eMMC controller doesn't have
> > regulator exposed to the system and have a single clock only for source
> > clock and only default pintctrl.
> >
> > Rework the schema to permit these new requirements and make supply
> > optional only for airoha,an7581-mmc compatible.
> >
> > Also provide an example for airoha,an7581-mmc.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> > This depends on patch merged in clk-next
> > bfe257f9780d8f77045a7da6ec959ee0659d2f98
> >
> > .../devicetree/bindings/mmc/mtk-sd.yaml | 64 +++++++++++++++++--
> > 1 file changed, 58 insertions(+), 6 deletions(-)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/mmc/mtk-sd.example.dts:104.31-32 syntax error
> FATAL ERROR: Unable to parse input tree
> make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/mmc/mtk-sd.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
> make: *** [Makefile:251: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250115073026.31552-1-ansuelsmth@gmail.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
Hi Rob, I think this fails as the CLK define is still not merged as said
this patch depends on bfe257f9780d8f77045a7da6ec959ee0659d2f98.
Any hint how to make your bot work with that?
--
Ansuel
next prev parent reply other threads:[~2025-01-15 8:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 7:29 [PATCH 1/2] dt-bindings: mmc: mtk-sd: Add eMMC for AN7581 Christian Marangi
2025-01-15 7:29 ` [PATCH 2/2] mmc: mtk-sd: add support for AN7581 MMC Host Christian Marangi
2025-01-15 9:33 ` Wenbin Mei (梅文彬)
2025-01-15 9:35 ` Christian Marangi
2025-01-16 7:01 ` Andy-ld Lu (卢东)
2025-01-20 17:29 ` Christian Marangi
2025-01-21 6:25 ` Andy-ld Lu (卢东)
2025-01-22 9:32 ` Christian Marangi
2025-01-23 1:42 ` Andy-ld Lu (卢东)
2025-01-27 11:41 ` Christian Marangi
2025-01-15 8:37 ` [PATCH 1/2] dt-bindings: mmc: mtk-sd: Add eMMC for AN7581 Rob Herring (Arm)
2025-01-15 8:39 ` Christian Marangi [this message]
2025-01-15 8:48 ` Krzysztof Kozlowski
2025-01-15 8:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67877449.df0a0220.cdd29.8807@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chaotian.jing@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=upstream@airoha.com \
--cc=wenbin.mei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).