From: Tero Kristo <t-kristo@ti.com>
To: Faiz Abbas <faiz_abbas@ti.com>, Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, paul@pwsan.com, tony@atomide.com,
linux-kernel@vger.kernel.org, bcousson@baylibre.com,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks
Date: Thu, 31 May 2018 16:29:56 +0300 [thread overview]
Message-ID: <678ef467-a235-91db-8bae-f249ad98eac8@ti.com> (raw)
In-Reply-To: <e7e3ade1-76b7-f216-ece5-bd64a55cede6@ti.com>
On 31/05/18 13:14, Faiz Abbas wrote:
> Hi,
>
> On Thursday 31 May 2018 09:33 AM, Rob Herring wrote:
>> On Wed, May 30, 2018 at 07:41:30PM +0530, Faiz Abbas wrote:
>>> Add clkctrl data for the m_can clocks and register it within the
> ...
>>>
>>> diff --git a/include/dt-bindings/clock/dra7.h b/include/dt-bindings/clock/dra7.h
>>> index 5e1061b15aed..d7549c57cac3 100644
>>> --- a/include/dt-bindings/clock/dra7.h
>>> +++ b/include/dt-bindings/clock/dra7.h
>>> @@ -168,5 +168,6 @@
>>> #define DRA7_COUNTER_32K_CLKCTRL DRA7_CLKCTRL_INDEX(0x50)
>>> #define DRA7_UART10_CLKCTRL DRA7_CLKCTRL_INDEX(0x80)
>>> #define DRA7_DCAN1_CLKCTRL DRA7_CLKCTRL_INDEX(0x88)
>>> +#define DRA7_ADC_CLKCTRL DRA7_CLKCTRL_INDEX(0xa0)
>>
>> ADC and mcan are the same thing?
>>
>
> The register to control MCAN clocks is called ADC_CLKCTRL, Yes.
Is there any reason for this or is that just a documentation bug?
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2018-05-31 13:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 14:11 [PATCH v2 0/6] Add MCAN Support for dra76x Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 1/6] ARM: dra762: hwmod: Add MCAN support Faiz Abbas
2018-05-30 14:50 ` Tony Lindgren
2018-05-30 15:15 ` Tero Kristo
2018-05-30 15:28 ` Tony Lindgren
2018-05-30 15:41 ` Tero Kristo
2018-05-30 15:54 ` Tony Lindgren
2018-05-31 6:15 ` Tero Kristo
2018-05-31 15:26 ` Tony Lindgren
2018-05-31 16:35 ` Faiz Abbas
2018-05-31 16:39 ` Tony Lindgren
2018-05-30 14:11 ` [PATCH v2 2/6] ARM: dts: dra762: Add MCAN clock support Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 3/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks Faiz Abbas
2018-05-31 4:03 ` Rob Herring
2018-05-31 10:14 ` Faiz Abbas
2018-05-31 13:29 ` Tero Kristo [this message]
2018-06-01 6:48 ` Faiz Abbas
2018-06-01 14:26 ` Tony Lindgren
2018-06-04 13:58 ` Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 4/6] bus: ti-sysc: Add support for using ti-sysc for MCAN on dra76x Faiz Abbas
2018-05-30 14:57 ` Tony Lindgren
2018-05-31 10:16 ` Faiz Abbas
2018-05-31 13:50 ` Tony Lindgren
2018-05-31 4:08 ` Rob Herring
2018-05-30 14:11 ` [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN Faiz Abbas
2018-05-30 15:04 ` Tony Lindgren
2018-05-31 10:21 ` Faiz Abbas
2018-05-31 13:45 ` Tony Lindgren
2018-05-31 16:38 ` Faiz Abbas
2018-05-31 4:06 ` Rob Herring
2018-05-31 11:26 ` Faiz Abbas
2018-05-31 13:41 ` Tony Lindgren
2018-06-02 6:32 ` Stephen Boyd
2018-06-04 5:49 ` Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 6/6] ARM: dts: dra76x: Add MCAN node Faiz Abbas
2018-05-30 15:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=678ef467-a235-91db-8bae-f249ad98eac8@ti.com \
--to=t-kristo@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).