public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "kristo@kernel.org" <kristo@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"nm@ti.com" <nm@ti.com>, "vigneshr@ti.com" <vigneshr@ti.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-pinctrl: Introduce Schmitt Trigger macros
Date: Tue, 1 Jul 2025 10:57:10 +0000	[thread overview]
Message-ID: <679f42499eb87ae8124e1bed79d2e73ef0eb992a.camel@siemens.com> (raw)
In-Reply-To: <20250627131332.2806026-1-alexander.sverdlin@siemens.com>

On Fri, 2025-06-27 at 15:13 +0200, A. Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> 
> Introduce ST_DISABLE and ST_ENABLE macros so that they can be used in
> conjunction with PIN_INPUT* macros, e.g. (PIN_INPUT | ST_ENABLE).
> 
> Note that K3 might have quite strict input slew rate requirements and
> all inputs actually have ST enabled on reset, but AM62PX_IOPAD macro
> will not preserve this power-on default config. Therefore ST_ENABLE
> is encouraged in many situations, especially if the input is to be
> used as IRQ trigger.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>

Please disregard in favour of patch
"arm64: dts: ti: k3-pinctrl: Enable Schmitt Trigger by default" [1].

[1] Link: https://lore.kernel.org/all/20250701105437.3539924-1-alexander.sverdlin@siemens.com/

> ---
>  arch/arm64/boot/dts/ti/k3-pinctrl.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> index cac7cccc11121..3e371be7b8062 100644
> --- a/arch/arm64/boot/dts/ti/k3-pinctrl.h
> +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> @@ -8,6 +8,7 @@
>  #ifndef DTS_ARM64_TI_K3_PINCTRL_H
>  #define DTS_ARM64_TI_K3_PINCTRL_H
>  
> +#define ST_EN_SHIFT		(14)
>  #define PULLUDEN_SHIFT		(16)
>  #define PULLTYPESEL_SHIFT	(17)
>  #define RXACTIVE_SHIFT		(18)
> @@ -44,6 +45,10 @@
>  #define PIN_DEBOUNCE_CONF5	(5 << DEBOUNCE_SHIFT)
>  #define PIN_DEBOUNCE_CONF6	(6 << DEBOUNCE_SHIFT)
>  
> +/* Schmitt trigger configuration */
> +#define ST_DISABLE		(0 << ST_EN_SHIFT)
> +#define ST_ENABLE		(1 << ST_EN_SHIFT)
> +
>  #define PIN_DS_FORCE_DISABLE		(0 << FORCE_DS_EN_SHIFT)
>  #define PIN_DS_FORCE_ENABLE		(1 << FORCE_DS_EN_SHIFT)
>  #define PIN_DS_IO_OVERRIDE_DISABLE	(0 << DS_IO_OVERRIDE_EN_SHIFT)

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

      reply	other threads:[~2025-07-01 10:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 13:13 [PATCH] arm64: dts: ti: k3-pinctrl: Introduce Schmitt Trigger macros A. Sverdlin
2025-07-01 10:57 ` Sverdlin, Alexander [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=679f42499eb87ae8124e1bed79d2e73ef0eb992a.camel@siemens.com \
    --to=alexander.sverdlin@siemens.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox