From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C43AC61DA4 for ; Thu, 9 Mar 2023 08:36:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230283AbjCIIgl (ORCPT ); Thu, 9 Mar 2023 03:36:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230027AbjCIIgY (ORCPT ); Thu, 9 Mar 2023 03:36:24 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FFE9E1FFB for ; Thu, 9 Mar 2023 00:34:33 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id ec29so3870511edb.6 for ; Thu, 09 Mar 2023 00:34:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678350871; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bf5h9B4GjXB46KIfBV4Jul3CUEr4UPwk87maz3zdFaU=; b=KYtpme7mZtwMcP/RYUD2GRhVzrQ79etsVr3hsmX/w3XpWtZTQ0Og7rqFqZ5FqcN1m7 6V13ODVLWHU/YzoZAe9aDmdScCZclp1d7DdPvgEkM5UzZoQnFHL0MpaAbUkrzdCuuJW1 83sCF1nebd4RTPpEjTtPlGRoDGVkqMoEbj0gWAPA4TJX7i6MnyLVyUfzrOGMgFMFMVkI QfrqlErzZ+s9Q/gG8qJ+XGP0yNZKp5+XbolfzSKvlS31Hb0zfj+3S60u1JQeRCIdn2Ez IYFwJxbVWte3S0rY2nOOITy8Rj43L9QwOt2g8sX1X1HLaYHzY+Fcr++/TSaHMRy51OYT y56Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678350871; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bf5h9B4GjXB46KIfBV4Jul3CUEr4UPwk87maz3zdFaU=; b=vz9cvghGd2sAP4rnRtTraZam/BQBEEHoKT2Ja8VwBYDTKx6cP2261HDaCsDJsvIV+B ge/0XRJw6TeJeg6ttRIGsEjZyOaNQsOnCR/JxbHILG9S1DznnvvKW9Sl8RMNAYoxci4j 63gqlKfDcd0Xna6Ee7RyN7+ndEKip2M+5p6bCzaJfinX8tg97zY0OMlnNQXwgEIB+iUf 2igk3ZYOm/MMONwrGKdWc+kmsXNCr7Rc1BptFM1fxUHaTVPTFVUmYeyij/16Jj+f5My3 VKmd7lT28AgoNAFGGTZKUvzqP4H0cRqe5dQmZd7j0ctu6eOcSq7nv9cF+udnv3+nZxBa aspg== X-Gm-Message-State: AO0yUKVmsu0XUZTWUM+hgHhLNUurtnkHBUbxreUZCYLJzJm5pnUuKnzQ l/VJAMwFfQWILGhkVxkjaT4wUA== X-Google-Smtp-Source: AK7set8CoMNWnVZzsifH057MaEVwmYB5sNqItMfusNWAvB1Iskv+7NVWFMrkezq1IqQcuXrPSGzXZA== X-Received: by 2002:a05:6402:150b:b0:4c1:bfa5:adfa with SMTP id f11-20020a056402150b00b004c1bfa5adfamr17173963edw.33.1678350870940; Thu, 09 Mar 2023 00:34:30 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:7ee2:e73e:802e:45c1? ([2a02:810d:15c0:828:7ee2:e73e:802e:45c1]) by smtp.gmail.com with ESMTPSA id p24-20020a50cd98000000b004af6163f845sm9169133edi.28.2023.03.09.00.34.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Mar 2023 00:34:30 -0800 (PST) Message-ID: <67b84336-4632-0b71-1c93-8fc975cea69b@linaro.org> Date: Thu, 9 Mar 2023 09:34:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 3/7] dt-bindings: remoteproc: mpss: Document QDU1000/QRU1000 mpss devices Content-Language: en-US From: Krzysztof Kozlowski To: Melody Olvera , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Jassi Brar , Mathieu Poirier , Robert Marko , Guru Das Srinagesh Cc: Konrad Dybcio , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20230306231202.12223-1-quic_molvera@quicinc.com> <20230306231202.12223-4-quic_molvera@quicinc.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/03/2023 09:33, Krzysztof Kozlowski wrote: > On 07/03/2023 00:11, Melody Olvera wrote: >> This documents the compatible for the component used to boot the > > Do not use "This commit/patch". > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > >> MPSS on the QDU1000 and QRU1000 SoCs. >> >> The QDU1000 and QRU1000 mpss boot process now requires the specification >> of an RMB register space to complete the handshake needed to start or >> attach the mpss. >> >> Signed-off-by: Melody Olvera >> --- >> .../remoteproc/qcom,qdu1000-mpss-pas.yaml | 130 ++++++++++++++++++ >> 1 file changed, 130 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,qdu1000-mpss-pas.yaml >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,qdu1000-mpss-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,qdu1000-mpss-pas.yaml >> new file mode 100644 >> index 000000000000..9cb4296c1fa6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,qdu1000-mpss-pas.yaml >> @@ -0,0 +1,130 @@ >> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/remoteproc/qcom,qdu1000-mpss-pas.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm QDU1000 Modem Peripheral Authentication Service >> + >> +maintainers: >> + - Melody Olvera >> + >> +description: >> + Qualcomm QDU1000 SoC Peripheral Authentication Service loads and boots firmware >> + on the Qualcomm DSP Hexagon core. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,qdu1000-mpss-pas >> + >> + reg: >> + maxItems: 2 > > You need to list the items instead (just like for clocks). > >> + >> + clocks: >> + items: >> + - description: XO clock >> + >> + clock-names: >> + items: >> + - const: xo >> + >> + qcom,qmp: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: Reference to the AOSS side-channel message RAM. >> + >> + smd-edge: false >> + >> + firmware-name: >> + $ref: /schemas/types.yaml#/definitions/string-array > > You can now drop the $ref. > >> + items: >> + - description: Firmware name of the Hexagon core >> + - description: Firmware name of the Hexagon Devicetree >> + >> + memory-region: >> + items: >> + - description: Memory region for main Firmware authentication >> + - description: Memory region for Devicetree Firmware authentication >> + - description: DSM Memory region >> + >> + interrupts: >> + minItems: 6 >> + >> + interrupt-names: >> + minItems: 6 >> + >> + interconnects: >> + minItems: 1 > > maxItems instead Wait, I already commented on this... Some other comments also ignored. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof