From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF267C05027 for ; Fri, 20 Jan 2023 17:19:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229943AbjATRTW (ORCPT ); Fri, 20 Jan 2023 12:19:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbjATRTV (ORCPT ); Fri, 20 Jan 2023 12:19:21 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81142BB9D; Fri, 20 Jan 2023 09:19:19 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 7190C3200A5C; Fri, 20 Jan 2023 12:19:17 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 20 Jan 2023 12:19:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1674235157; x=1674321557; bh=AN63Zk9FUH XtB/1LDWKyjPugYkaPfboH8yCsuuO7QPs=; b=ta4oy1s1AdxLORjET+xauHRdR5 NcbGi5cLHSey+FpTmv5ZC193wrgm2ovoDrIuYhzJXXZ+i5vJeQ4SoRHyB5D5KecC iXNUbnN4wzRnjQD6svlrGR+wUvYwpEGj1XRFU+HFOQ12Hb6tTPfdSYMU/skLOmo8 w9Xr5VvQq3L5bgx2LNbZvWNgaNyJGfAtFx4+RyOlcvgLX7fLr1tDHcwtXMGOqXed 3/TATPBktImtX56gMo7xDgc4nU3KmumzhQd/Elz7DPmbgOYOWhAGJ9joeV4gFi/i aD5MlNtMOIjQvp0yk+7265KbkmfReznpXigOGwvTGcmENPdEli46eemx7fhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674235157; x=1674321557; bh=AN63Zk9FUHXtB/1LDWKyjPugYkaP fboH8yCsuuO7QPs=; b=l/OkIMIlYk2aLfnTY+EPhfjYf3kNra1kPmw+smJwoPT2 K7Uxj4cdQhaKrOlaRHvPok1/HLjAzDXAJHG46jslpUERDQ51cFxlaWPRnXSekrMO g1T5kI0e6HDJ3iMgHZxQB8X/SzkjhE8Y1J3u5H3qJwgKNnDMmrim2ahfSXkDfTD4 BRr3gLLTRZ8GZLPqIDy/SA9UzIDv0WVuhOnWN533RUAbI/juEZzoxij8Og0thReG IZp8bm5GrqAvCBVDZZYbvUtXUwo9dnI8hWotJ/u4gZ4i6ORoGrBUHexzWx7pN55+ xvPfmkak4Tl03QIZjujVXwPUYWHrVtntkSYy9SxNlw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudduvddguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0A0C0B60086; Fri, 20 Jan 2023 12:19:15 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0 Mime-Version: 1.0 Message-Id: <67c572e1-20ca-4ed2-9e15-047341bb338b@app.fastmail.com> In-Reply-To: <20230120133455.3962413-11-alexander.stein@ew.tq-group.com> References: <20230120133455.3962413-1-alexander.stein@ew.tq-group.com> <20230120133455.3962413-11-alexander.stein@ew.tq-group.com> Date: Fri, 20 Jan 2023 18:18:54 +0100 From: "Arnd Bergmann" To: "Alexander Stein" , "Rob Herring" , "Krzysztof Kozlowski" , "Olof Johansson" , "Shawn Guo" , "Li Yang" , "Russell King" , "Marek Vasut" , "Marcel Ziswiler" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Masahiro Yamada" , "Nathan Chancellor" , "Nick Desaulniers" , "Nicolas Schier" Cc: "Nicolas Saenz Julienne" , soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH v2 10/10] ARM: add multi_v7_lpae_defconfig Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jan 20, 2023, at 14:34, Alexander Stein wrote: > From: Nicolas Saenz Julienne > > The only missing configuration option preventing us from using > multi_v7_defconfig with the Raspberry Pi 4 is ARM_LPAE. It's needed as > the PCIe controller found on the SoC depends on 64bit addressing, yet > can't be included as not all v7 boards support LPAE. > > Introduce multi_v7_lpae_defconfig, built off multi_v7_defconfig, which will > avoid us having to duplicate and maintain multiple similar configurations. > > Needless to say the Raspberry Pi 4 is not the only platform that can > benefit from this new configuration. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Alexander Stein This is ok in principle, two minor points though: > +include $(srctree)/scripts/Makefile.defconf > +PHONY += multi_v7_lpae_defconfig > +multi_v7_lpae_defconfig: > + $(call merge_into_defconfig,multi_v7_defconfig,lpae) > > define archhelp > echo '* zImage - Compressed kernel image (arch/$(ARCH)/boot/zImage)' The new target does not get listed in 'make help' as far as I can tell, can you add it there in the process? > diff --git a/arch/arm/configs/lpae.config b/arch/arm/configs/lpae.config > new file mode 100644 > index 0000000000000..19bab134e014b > --- /dev/null > +++ b/arch/arm/configs/lpae.config > @@ -0,0 +1 @@ > +CONFIG_ARM_LPAE=y My feeling is that we probably want CONFIG_VMSPLIT_2G=y here as well, given that a lot of the systems that want LPAE will have a lot of memory, and are limited by the amount of lowmem even when CONFIG_HIGHMEM is enabled. Can you make sure that this works on your machine, and include this option? Arnd