From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Taniya Das <taniya.das@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] clk: qcom: Add EVA clock controller driver for Glymur SoC
Date: Thu, 11 Jun 2026 14:00:14 +0200 [thread overview]
Message-ID: <67d7280f-54e5-4e16-931c-92049bee3e00@oss.qualcomm.com> (raw)
In-Reply-To: <20260526-evacc_glymur-v1-3-b61c7755c403@oss.qualcomm.com>
On 5/26/26 7:29 AM, Taniya Das wrote:
> Add the Enhanced Video Analytics (EVA) clock controller driver for
> the Glymur SoC. The EVACC manages the PLL, RCGs, branch clocks, GDSCs
> and resets for the EVA subsystem which handles vision processing
> workloads.
>
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---
[...]
> +enum {
> + DT_AHB_CLK,
> + DT_BI_TCXO,
> + DT_BI_TCXO_AO,
DT_BI_TCXO_AO is unused, will it ever be?
[...]
> +static void clk_glymur_regs_configure(struct device *dev, struct regmap *regmap)
> +{
> + /* Update CTRL_IN register */
Is there any better comment we could share here?
> + regmap_update_bits(regmap, 0x9f24, BIT(0), BIT(0));
regmap_set_bits()
otherwise lgtm
Konrad
next prev parent reply other threads:[~2026-06-11 12:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 5:29 [PATCH 0/4] clk: qcom: Add EVA clock controller support for Glymur SoC Taniya Das
2026-05-26 5:29 ` [PATCH 1/4] clk: qcom: gcc-glymur: Move EVA clocks to critical clock list Taniya Das
2026-05-26 5:46 ` Dmitry Baryshkov
2026-05-26 7:07 ` Taniya Das
2026-05-26 7:12 ` Dmitry Baryshkov
2026-06-11 12:01 ` Konrad Dybcio
2026-06-16 6:19 ` Taniya Das
2026-05-26 5:29 ` [PATCH 2/4] dt-bindings: clock: qcom: Add EVA clock and reset controller for Glymur SoC Taniya Das
2026-06-04 19:08 ` Rob Herring
2026-05-26 5:29 ` [PATCH 3/4] clk: qcom: Add EVA clock controller driver " Taniya Das
2026-06-11 12:00 ` Konrad Dybcio [this message]
2026-06-16 6:30 ` Taniya Das
2026-05-26 5:29 ` [PATCH 4/4] arm64: dts: qcom: glymur: Add EVA clock controller node Taniya Das
2026-05-26 6:00 ` Dmitry Baryshkov
2026-05-26 7:08 ` Taniya Das
2026-06-11 12:00 ` Konrad Dybcio
2026-06-16 6:31 ` Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d7280f-54e5-4e16-931c-92049bee3e00@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox