From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B0CC433FE for ; Fri, 1 Apr 2022 14:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347764AbiDAOf5 (ORCPT ); Fri, 1 Apr 2022 10:35:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347404AbiDAOcb (ORCPT ); Fri, 1 Apr 2022 10:32:31 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00EFC1EC60D for ; Fri, 1 Apr 2022 07:28:54 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id g22so3196828edz.2 for ; Fri, 01 Apr 2022 07:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=1adJU3bhpcLZT1nUnce0EbLAPPbeXtcoClCStkyt9oM=; b=VZ39SYrJ6PEuCxfqeqF/rIXuHwNzeIMR4RSC49UzVjrWCxHsx0BHlKRiOJeA1aqUBh na4Lqb60PW31/7aJkHlKz9+Z08pkCtFhMyaXwX8Iy9jpon6g4s2pKRT0RCBleow+tdtW QEiPis/ejow0d2ueveCIyUc4iwSnr38jDYFT1GE4dFhiPG2Udvvm/zmLMNbKxlfnEv9T xXEkatWlkg9mzdM+9/XY5ee1SCfy1wGgdgcSrCJTna7dFOWET+ne5lUiyS7OR2YiKL05 F4AECbU5SrJABBKxCxYd09Lp7o/CQMl/NRSvMaytCitplDniftvzBoHs8IuJsmG2EI/r 5AOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1adJU3bhpcLZT1nUnce0EbLAPPbeXtcoClCStkyt9oM=; b=M3CujUt2UcJqgKoqN/ErJF/r/TApyn/8KqXkp9uTpxRykRrAaWEgfEGIne0Y2tIova nnfOs1OyKSfX+X2y+tKv8uZSV8wQHqQWPnh6P1kNwqFlh3oeyKHvfVqTbtVpvlhHtfw+ ft2g7OJ0uxgd4Cct8DIuwds74uuyJGTKMEDqFjGues2wQHrL3dNAvscPWEHOQ6SDL/it usWlBpgj+9C5W4MfdZVTxbjvPxBUKf6n2lRWCb14CisvWRppRx4OFIVEIVLfzTQ2WBiH 7yCupEDAqXkAZUeg6r5JiW//vu0g3OfnohuJ9CxJFatly4u7TcK/5xQmfOpNZbQbKcRe 9SRg== X-Gm-Message-State: AOAM532LUvyrRi3nzqRzWCTUtM39qSRqzoo4X6QUXMi0dT0QOEchkj75 YIwTwYucCiKD2Qat8L74EjF/9w== X-Google-Smtp-Source: ABdhPJwzpAYQRuMQgEMzKTOmbEnykgFo3n9w7xJ0j1Au8dBsZfXNwd8pz6gGo426T8lHlCYDUd4yPw== X-Received: by 2002:a05:6402:2681:b0:419:4564:1bd4 with SMTP id w1-20020a056402268100b0041945641bd4mr21552795edd.358.1648823333577; Fri, 01 Apr 2022 07:28:53 -0700 (PDT) Received: from [192.168.0.170] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id f17-20020a056402355100b0041925e80963sm1285501edd.41.2022.04.01.07.28.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Apr 2022 07:28:53 -0700 (PDT) Message-ID: <67df9824-898c-192f-7baf-a1f05936f0ab@linaro.org> Date: Fri, 1 Apr 2022 16:28:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] spi: dt-bindings: qcom,spi-geni-qcom: convert to dtschema Content-Language: en-US To: Kuldeep Singh Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Mark Brown , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org References: <20220331160248.716234-1-krzysztof.kozlowski@linaro.org> <20220331175817.GA91341@9a2d8922b8f1> <20220401135224.GA40286@9a2d8922b8f1> From: Krzysztof Kozlowski In-Reply-To: <20220401135224.GA40286@9a2d8922b8f1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/04/2022 15:52, Kuldeep Singh wrote: > On Thu, Mar 31, 2022 at 09:40:08PM +0200, Krzysztof Kozlowski wrote: >> On 31/03/2022 19:58, Kuldeep Singh wrote: >>> On Thu, Mar 31, 2022 at 06:02:47PM +0200, Krzysztof Kozlowski wrote: >>>> Convert the GENI based Qualcomm Universal Peripheral (QUP) Serial >>>> Peripheral Interface (SPI) bindings to DT Schema. >>>> >>>> The original bindings in TXT were not complete, so add during conversion >>>> properties already used in DTS and/or in the driver: reg-names, dmas, >>>> interconnects, operating points and power-domains. >>>> >>>> Signed-off-by: Krzysztof Kozlowski > > [...] > >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + reg-names: >>>> + const: se >>> >>> Why reg-names is required? >>> Reg contain max 1 value, we can skip reg-names like other users. >>> >>> Also, "se" is used as clock name and using it again for reg-names? >>> I think this is wrong and reg-names shouldn't be documented. >> >> reg-names are not required. If you ask why they are documented? As I >> wrote in commit msg - bindings were not fully updated to DTSes being used. > > Hi Krzysztof, > > Power-domains, operating-points etc. makes sense, but reg-names? > > With quick search, sm8150.dtsi is the only user of reg-names. Moreover, > there is no reference in driver to incorporate it. > Driver(drivers/spi/spi-geni-qcom.c) looks for "se" as clock name and not > as reg-name. If there's one, kindly help in pointing out. > > It seems you are adding reg-names because some DT is using it and no > other reason. And with no reference even in driver, that's surely not a > way to go ahead as you have been advising the same in past. I don't mind dropping it. Best regards, Krzysztof