From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manuel Traut <manuel.traut@mt.com>, linux-kernel@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 3/4] dt-bindings: input: pwm-beeper: add volume
Date: Wed, 1 Feb 2023 09:37:18 +0100 [thread overview]
Message-ID: <67ecd5d1-ab61-c9d2-b143-398a678a614d@linaro.org> (raw)
In-Reply-To: <20230130135650.1407156-4-manuel.traut@mt.com>
On 30/01/2023 14:56, Manuel Traut wrote:
> Adds an array of supported volume levels and a default volume level.
>
> Signed-off-by: Manuel Traut <manuel.traut@mt.com>
> ---
> .../devicetree/bindings/input/pwm-beeper.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml
> index 1ebc3a46d934..ca9efab7efbf 100644
> --- a/Documentation/devicetree/bindings/input/pwm-beeper.yaml
> +++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml
> @@ -25,6 +25,21 @@ properties:
> beeper-hz:
> description: bell frequency in Hz
>
> + volume-levels-bp:
> + description: >
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-01 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 13:56 [PATCH v9 0/4] input: pwm-beeper: add feature to set volume level Manuel Traut
2023-01-30 13:56 ` [PATCH v9 1/4] dt-bindings: input: pwm-beeper: Convert txt bindings to yaml Manuel Traut
2023-01-30 23:00 ` Rob Herring
2023-01-30 13:56 ` [PATCH v9 2/4] input: pwm-beeper: add feature to set volume via sysfs Manuel Traut
2023-01-30 13:56 ` [PATCH v9 3/4] dt-bindings: input: pwm-beeper: add volume Manuel Traut
2023-01-30 15:29 ` Rob Herring
2023-02-01 8:37 ` Krzysztof Kozlowski [this message]
2023-01-30 13:56 ` [PATCH v9 4/4] input: pwm-beeper: set volume levels by devicetree Manuel Traut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67ecd5d1-ab61-c9d2-b143-398a678a614d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.traut@mt.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).