public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pradeep Pragallapati <pradeep.pragallapati@oss.qualcomm.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Cc: vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	martin.petersen@oracle.com, andersson@kernel.org,
	konradybcio@kernel.org, taniya.das@oss.qualcomm.com,
	dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	nitin.rawat@oss.qualcomm.com,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Abel Vesa <abel.vesa@oss.qualcomm.com>
Subject: Re: [PATCH V3 3/4] arm64: dts: qcom: hamoa: Add UFS nodes for x1e80100 SoC
Date: Tue, 6 Jan 2026 14:40:30 +0100	[thread overview]
Message-ID: <67fd0c34-0ea4-461c-8586-4eaca678ccb3@kernel.org> (raw)
In-Reply-To: <e396bef2-e5bf-4e6d-98f4-37977d5d93ec@oss.qualcomm.com>

On 06/01/2026 14:00, Pradeep Pragallapati wrote:
>>
>>> +			compatible = "qcom,x1e80100-ufshc",
>>> +				     "qcom,sm8550-ufshc",
>>> +				     "qcom,ufshc",
>>> +				     "jedec,ufs-2.0";
>>
>> Drop jedec compatible as Qcom UFS controller cannot fallback to generic ufshc
>> driver.
> "jedec,ufs-2.0" was set to const in dt-bindings, dropping now will lead 
> to dtbs_check failures. is it ok, if i continue with it ?

No, it is not ok. You cannot have errors/warnings and I think it is
obvious that you need to fix everything, not only DTS.

Best regards,
Krzysztof

  reply	other threads:[~2026-01-06 13:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05 14:46 [PATCH V3 0/4] Add UFS support for x1e80100 SoC Pradeep P V K
2026-01-05 14:46 ` [PATCH V3 1/4] dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: Add QMP UFS PHY compatible Pradeep P V K
2026-01-06  7:32   ` Krzysztof Kozlowski
2026-01-05 14:46 ` [PATCH V3 2/4] dt-bindings: ufs: qcom,sc7180-ufshc: Add UFSHC compatible for x1e80100 Pradeep P V K
2026-01-06  7:34   ` Krzysztof Kozlowski
2026-01-06  8:03   ` Manivannan Sadhasivam
2026-01-05 14:46 ` [PATCH V3 3/4] arm64: dts: qcom: hamoa: Add UFS nodes for x1e80100 SoC Pradeep P V K
2026-01-06  8:06   ` Manivannan Sadhasivam
2026-01-06 13:00     ` Pradeep Pragallapati
2026-01-06 13:40       ` Krzysztof Kozlowski [this message]
2026-01-06 13:51         ` Pradeep Pragallapati
2026-01-06 13:52       ` Manivannan Sadhasivam
2026-01-06 14:11         ` Pradeep Pragallapati
2026-01-05 14:46 ` [PATCH V3 4/4] arm64: dts: qcom: hamoa-iot-evk: Enable UFS Pradeep P V K
2026-01-05 22:20 ` [PATCH V3 0/4] Add UFS support for x1e80100 SoC Dmitry Baryshkov
2026-01-06 13:03   ` Pradeep Pragallapati
2026-01-06 16:41     ` Bjorn Andersson
2026-01-07  5:51       ` Pradeep Pragallapati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67fd0c34-0ea4-461c-8586-4eaca678ccb3@kernel.org \
    --to=krzk@kernel.org \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=martin.petersen@oracle.com \
    --cc=neil.armstrong@linaro.org \
    --cc=nitin.rawat@oss.qualcomm.com \
    --cc=pradeep.pragallapati@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=taniya.das@oss.qualcomm.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox