Re: [PATCH] arm64: dts: rockchip: Enable second HDMI output on CM3588

["Heiko Stübner" <heiko@sntech.de>]

Hi David,

Am Sonntag, 19. Oktober 2025, 16:20:53 Mitteleuropäische Sommerzeit schrieb David Petry:
> Enable the second HDMI output port found on FriendlyElec CM3588 and CM3588

the decription sounds like you're referencing two boards, but the change
itself only touches one. Is there a 2nd patch missing or does the wording
above need improvement?

Thanks
Heiko

> 
> Signed-off-by: David Petry <petry103@gmail.com>
> ---
>  .../rk3588-friendlyelec-cm3588-nas.dts        | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts b/arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts
> index 5fbbeb6f5a935..10a7d3691a26f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts
> @@ -101,6 +101,17 @@ hdmi0_con_in: endpoint {
>  		};
>  	};
>  
> +	hdmi1-con {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi1_con_in: endpoint {
> +				remote-endpoint = <&hdmi1_out_con>;
> +			};
> +		};
> +	};
> +
>  	ir-receiver {
>  		compatible = "gpio-ir-receiver";
>  		gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_LOW>;
> @@ -335,6 +346,22 @@ hdmi0_out_con: endpoint {
>  	};
>  };
>  
> +&hdmi1 {
> +	status = "okay";
> +};
> +
> +&hdmi1_in {
> +	hdmi1_in_vp1: endpoint {
> +		remote-endpoint = <&vp1_out_hdmi1>;
> +	};
> +};
> +
> +&hdmi1_out {
> +	hdmi1_out_con: endpoint {
> +		remote-endpoint = <&hdmi1_con_in>;
> +	};
> +};
> +
>  &hdmi_receiver_cma {
>  	status = "okay";
>  };
> @@ -350,6 +377,10 @@ &hdptxphy0 {
>  	status = "okay";
>  };
>  
> +&hdptxphy1 {
> +	status = "okay";
> +};
> +
>  /* Connected to MIPI-DSI0 */
>  &i2c5 {
>  	pinctrl-names = "default";
> @@ -840,3 +871,10 @@ vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
>  		remote-endpoint = <&hdmi0_in_vp0>;
>  	};
>  };
> +
> +&vp1 {
> +	vp1_out_hdmi1: endpoint@ROCKCHIP_VOP2_EP_HDMI1 {
> +		reg = <ROCKCHIP_VOP2_EP_HDMI1>;
> +		remote-endpoint = <&hdmi1_in_vp1>;
> +	};
> +};
>