From: Vivian Wang <wangruikang@iscas.ac.cn>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Richard Cochran <richardcochran@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Russell King <linux@armlinux.org.uk>, Vivian Wang <uwu@dram.page>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] net: spacemit: Add K1 Ethernet MAC
Date: Mon, 16 Jun 2025 11:02:59 +0800 [thread overview]
Message-ID: <680be7d5-9cb4-4c8f-814e-7f22d9304d06@iscas.ac.cn> (raw)
In-Reply-To: <20250613063145.62871999@kernel.org>
Hi Jakub,
Thanks for your review.
On 6/13/25 21:31, Jakub Kicinski wrote:
> On Fri, 13 Jun 2025 10:15:08 +0800 Vivian Wang wrote:
>> + rx_ring->desc_addr = dma_alloc_coherent(&pdev->dev, rx_ring->total_size,
>> + &rx_ring->desc_dma_addr,
>> + GFP_KERNEL);
>> + if (!rx_ring->desc_addr) {
>> + kfree(rx_ring->rx_desc_buf);
>> + return -ENOMEM;
>> + }
>> +
>> + memset(rx_ring->desc_addr, 0, rx_ring->total_size);
> dma_alloc_coherent() already clears memory.
Thanks, I will remove memset in next version.
Regards,
Vivian "dramforever" Wang
next prev parent reply other threads:[~2025-06-16 3:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 2:15 [PATCH net-next 0/4] Add Ethernet MAC support for SpacemiT K1 Vivian Wang
2025-06-13 2:15 ` [PATCH net-next 1/4] dt-bindings: net: Add " Vivian Wang
2025-06-13 14:43 ` Conor Dooley
2025-06-13 2:15 ` [PATCH net-next 2/4] net: spacemit: Add K1 Ethernet MAC Vivian Wang
2025-06-13 13:31 ` Jakub Kicinski
2025-06-16 3:02 ` Vivian Wang [this message]
2025-06-13 14:32 ` Andrew Lunn
2025-06-16 3:04 ` Vivian Wang
2025-06-13 15:04 ` Vadim Fedorenko
2025-06-16 3:04 ` Vivian Wang
2025-06-16 6:33 ` Russell King (Oracle)
2025-06-16 6:41 ` Vivian Wang
2025-06-13 2:15 ` [PATCH net-next 3/4] riscv: dts: spacemit: Add Ethernet support for K1 Vivian Wang
2025-06-13 2:15 ` [PATCH net-next 4/4] riscv: dts: spacemit: Add Ethernet support for BPI-F3 Vivian Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=680be7d5-9cb4-4c8f-814e-7f22d9304d06@iscas.ac.cn \
--to=wangruikang@iscas.ac.cn \
--cc=alex@ghiti.fr \
--cc=andrew+netdev@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=uwu@dram.page \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).