From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B94C001B0 for ; Tue, 27 Jun 2023 07:30:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbjF0Hae (ORCPT ); Tue, 27 Jun 2023 03:30:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231713AbjF0HaB (ORCPT ); Tue, 27 Jun 2023 03:30:01 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D23811FF3 for ; Tue, 27 Jun 2023 00:29:58 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3fb10fd9ad3so15001915e9.0 for ; Tue, 27 Jun 2023 00:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687850997; x=1690442997; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qjboc+xRA+5/Im3aAxTzJEYSFeQipRxlSvx/9SK3lrU=; b=oi3ilyANNmTm2Aaqmp0ktOiRHJLm2A6c62aNuawNccYP71KS5yUdkwgjTCLXl9aZ4+ IIlXa1NJ6sTz1fNMpZvL/wJpTnfkm3RIWhcgJd3k9rxLeLrhxPwZJ0tuLPD6MeFyuLkS +iQ7218KUpqhm/9gowun6cVYQuo/cUaDCn2vWfU1QDT3MQ8yTCfj0o1DEUwTlWS8YqtY zj5cY+RonNHvDloEOkZ/2zphBYbDH34dkDJPz+qnJwVVu8lFp1AUkI9/5HER1vtGIbSe gWHNAQzy65uG4+HLgv62CJ+lf39DqieRY5/BBAXtFMbJ99NnlOwbRzhvyrKpbT8oH270 xzrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687850997; x=1690442997; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qjboc+xRA+5/Im3aAxTzJEYSFeQipRxlSvx/9SK3lrU=; b=bIEpFRHqa9P4Nop4YaPipil7a1y3PjdLKhu8hr770/jSr5Ssh8H3kuVhwnUqlKVYHJ ou/u7r+QyIz5BykJ0vHmJFQ6qBDRGIvoe4FD13h8tZfb8xy3h+sdUvy8ujZPXgVPD8bT A/Y5S/IKKRT5JxHBGUtJnocjNWCjYumf97BJeT3wVR2xtR9gwGjIv1DshJURKweLOMFi 1CK5TAgCWoL7UhS1sbKn/eyKjFIi8jnCaQXUYpd4QsuLytxvKtExCvhVQ7W5rl8mXpac 12bCXO1QHfL42j+i/tf7foQsrdLsAxX4vrKun5LpNEHF1GAgCqKE0ElnCwSs19VH+AD7 EKew== X-Gm-Message-State: AC+VfDyGsxDUjitwUU7AYKHX1/LBmnEZ2/wXhIJNM4iVVYyI0zkVO+WY 6Z+R/UgFwMt2OW9QZ3BOCw/ejQ== X-Google-Smtp-Source: ACHHUZ51W0XH+MCfGadI2HPaObAXxQwBLGQlelvw5W3jHORJ6RAko8vEzlCs6yHDqMqGAAsQ8Ej2ag== X-Received: by 2002:a1c:7419:0:b0:3f9:b79d:a5fa with SMTP id p25-20020a1c7419000000b003f9b79da5famr16403219wmc.16.1687850997154; Tue, 27 Jun 2023 00:29:57 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id h10-20020a5d504a000000b00313e8dc7facsm7714556wrt.116.2023.06.27.00.29.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 00:29:56 -0700 (PDT) Message-ID: <683a6f7e-bf1a-aff2-070b-472fb14e0353@linaro.org> Date: Tue, 27 Jun 2023 09:29:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: Require GCC PLL0 DIV clock To: Marijn Suijten Cc: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Lux Aliaga References: <20230624-sm6125-dpu-v1-3-1d5a638cebf2@somainline.org> <55b0ca89-8f2e-5383-59d4-6809e813abf8@linaro.org> <52c57cab-10cf-2e7e-2c1d-fa6506786d45@linaro.org> <6311f26f-79ee-c471-649f-5e0b4629cfcc@linaro.org> <16731023-7dc7-d43d-1b16-fda44c0948ed@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/06/2023 08:54, Marijn Suijten wrote: > On 2023-06-27 08:24:41, Krzysztof Kozlowski wrote: >> On 26/06/2023 20:53, Marijn Suijten wrote: >>> On 2023-06-26 20:51:38, Marijn Suijten wrote: >>> >>>>> Not really, binding also defines the list of clocks - their order and >>>>> specific entries. This changes. >>>> >>>> And so it does in "dt-bindings: clock: qcom,dispcc-sm6125: Remove unused >>>> GCC_DISP_AHB_CLK"? >>> >>> Never mind: it is the last item so the order of the other items doesn't >>> change. The total number of items decreases though, which sounds like >>> an ABI-break too? >> >> How does it break? Old DTS works exactly the same, doesn't it? > > So deleting a new item at the end does not matter. But what if I respin > this patch to add the new clock _at the end_, which will then be at the > same index as the previous GCC_DISP_AHB_CLK? I think you know the answer, right? What do you want to prove? That two independent changes can have together negative effect? We know this. Best regards, Krzysztof