Re: [PATCH v4 3/6] dt-bindings: PCI: qcom: Add IPQ5018 SoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/03/2025 09:42, George Moussalem wrote:
>>> +        reg-names:
>>> +          items:
>>> +            - const: parf # Qualcomm specific registers
>>> +            - const: dbi # DesignWare PCIe registers
>>> +            - const: elbi # External local bus interface registers
>>> +            - const: atu # ATU address space
>>> +            - const: config # PCIe configuration space
>>
>> Keep the same order as other IPQ, so dbi+elbi+atu+parf+config. Same for
>> everything else, so standard rule applies: devices are supposed to use
>> ordering from existing variants.
>>
>> There is some huge mess with IPQ PCI bindings, including things on the
>> list. Apparently it became my job to oversee Qualcomm PCI work... well,
>> I do not have time for that, so rather I expect contributors to
>> cooperate in this matter.
>>
>> Don't throw your patches over the wall.
>>
>> If you need to rework the patch, take the ownership and rework it.
>>
>>
> 
> Thanks Krzysztof. I did reorder them deliberately based on unit 
> addresses as discussed also in other threads about IPQ9574 and IPQ5332 
> as I thought it would be neater that way. I'll change it back, reuse 

Which discusses were that? What were the reasons to start with parf?


> other sections in the dt as much as possible, and follow your guidance 
> instead.

Best regards,
Krzysztof