From: Guenter Roeck <linux@roeck-us.net>
To: Ming Yu <a0282524688@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
tmyu0@nuvoton.com, lars@metafoo.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, cmo@melexis.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH v1 0/2] Add Nuvoton NCT7718W IIO driver
Date: Mon, 2 Dec 2024 06:56:40 -0800 [thread overview]
Message-ID: <6867cd67-9ab9-4a5c-902a-e2d14b846c51@roeck-us.net> (raw)
In-Reply-To: <CAOoeyxUyi_HKLH64Sokd9YU9vDnuizBaP2AOUYqQ8hTvJKo2-g@mail.gmail.com>
On Mon, Dec 02, 2024 at 05:22:52PM +0800, Ming Yu wrote:
> Dear Jonathan,
>
> Thank you for your reply, I'll move the driver to HWMON.
AFAICS the chip is compatible to lm90, so please add support for
it to the lm90 driver. Note that this also applies to NCT7717, which
looks like an internal-sensor-only version of the same chip.
> Additionally, for conventional ADC, Thermal sensor, and tachometer
> like chips, would it be more appropriate to implement them in HWMON?
>
Thermal sensor and tachometer, yes. For ADC it depends on the use case.
If the ADC is used for hardware monitoring (which is typically the case
if it has limit and alert support), yes. If it is a pure ADC, IIO
is a better place.
Thanks,
Guenter
prev parent reply other threads:[~2024-12-02 14:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 7:40 [PATCH v1 0/2] Add Nuvoton NCT7718W IIO driver Ming Yu
2024-11-26 7:40 ` [PATCH v1 1/2] dt-bindings: iio: temperature: Add support for NCT7718W Ming Yu
2024-11-26 17:58 ` Conor Dooley
2024-11-27 8:21 ` Ming Yu
2024-11-26 7:40 ` [PATCH v1 2/2] iio: temperature: Add Nuvoton NCT7718W support Ming Yu
2024-11-30 20:39 ` Jonathan Cameron
2024-12-02 9:30 ` Ming Yu
2024-11-30 20:28 ` [PATCH v1 0/2] Add Nuvoton NCT7718W IIO driver Jonathan Cameron
2024-11-30 20:50 ` Guenter Roeck
2024-12-02 9:27 ` Ming Yu
2024-12-02 9:22 ` Ming Yu
2024-12-02 14:56 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6867cd67-9ab9-4a5c-902a-e2d14b846c51@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a0282524688@gmail.com \
--cc=cmo@melexis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tmyu0@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox