Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Coia Prant <coiaprant@gmail.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Dragan Simic <dsimic@manjaro.org>,
	Jonas Karlman <jonas@kwiboo.se>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: arm: rockchip: Add NineTripod X3568 series
Date: Tue, 28 Oct 2025 22:09:05 +0100	[thread overview]
Message-ID: <68765cf5-0377-4c7a-a82a-7645fae0b142@kernel.org> (raw)
In-Reply-To: <20251026150358.1078453-2-coiaprant@gmail.com>

On 26/10/2025 16:03, Coia Prant wrote:
> This documents NineTripod X3568 v4 which is a SBC based on RK3568 SoC.
> 
> Link: http://www.9tripod.com/showpro.php?id=117
> Link: https://appletsapi.52solution.com/media/X3568V4%E5%BC%80%E5%8F%91%E6%9D%BF%E7%A1%AC%E4%BB%B6%E6%89%8B%E5%86%8C.pdf
> 
> Signed-off-by: Coia Prant <coiaprant@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 6aceaa8ac..417100209 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -777,6 +777,12 @@ properties:
>            - const: netxeon,r89
>            - const: rockchip,rk3288
>  
> +      - description: NineTripod X3568 series board
> +        items:
> +          - enum:
> +              - ninetripod,x3568-v4


You are supposed to use domain name as prefix. 9tripod

Don't send new versions 30 minutes after sending previous one. Allow
people to actually review.

You have now comments at v3 and here. You must implement them all.

Best regards,
Krzysztof

  parent reply	other threads:[~2025-10-28 21:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-26 15:03 [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add NineTripod Coia Prant
2025-10-26 15:03 ` [PATCH v4 2/3] dt-bindings: arm: rockchip: Add NineTripod X3568 series Coia Prant
2025-10-27 19:33   ` Rob Herring (Arm)
2025-10-28 21:09   ` Krzysztof Kozlowski [this message]
2025-10-26 15:03 ` [PATCH v4 3/3] arm64: dts: rockchip: Add devicetree for the NineTripod X3568 v4 Coia Prant
2025-10-26 16:27 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add NineTripod Krzysztof Kozlowski
2025-10-26 17:14 ` Coia Prant
2025-10-27 19:33 ` Rob Herring (Arm)
2025-10-28 21:10 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68765cf5-0377-4c7a-a82a-7645fae0b142@kernel.org \
    --to=krzk@kernel.org \
    --cc=coiaprant@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=heiko@sntech.de \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox