Re: [PATCH v10 0/8] Add StarFive Camera Subsystem driver

[Jack Zhu <jack.zhu@starfivetech.com>]

On 2023/10/18 16:50, Hans Verkuil wrote:
> Hi Jack,
> 
> On 18/10/2023 04:37, Jack Zhu wrote:
> 
> <snip>
> 
>>>> --------------------------------------------------------------------------------
>>>> Compliance test for device /dev/v4l-subdev1:
>>>>
>>>> Driver Info:
>>>> 	Driver version   : 6.6.0
>>>> 	Capabilities     : 0x00000000
>>>
>>> But this does not appear for v4l-subdev1.
>>>
>>> I can't really tell why it doesn't show that. Can you debug a little bit?
>>> The code is in v4l2-compliance.cpp, line 1086:
>>>
>>> ent_id = mi_media_info_for_fd(media_fd, node.g_fd(), &is_invalid, &node.function);
>>>
>>> The mi_media_info_for_fd() function calls ioctl(media_fd, MEDIA_IOC_DEVICE_INFO, &mdinfo),
>>> and that fails for some reason. It could be that media_fd is invalid (would be weird).
>>>
>>> This could well be a v4l2-compliance bug that you hit with this driver.
>>>
>> 
>> On the test board, /dev/v4l-subdev1 is imx219, and the corresponding directory is
>> /sys/dev/char/81:3/device. Media0 does not exist in this directory. Therefore, the media_fd
>> obtained through mi_get_media_fd(node.g_fd(), node.bus_info) is invalid.
>> 
>> I don't know why media0 does not exist in /sys/dev/char/81:3/device?
>> 
> 
> Can you try again with this v4l2-compliance patch?
> 
> I need to dig a bit deeper as to why media0 is missing, but for now try this.
> 
> Regards,
> 
> 	Hans
> 
> diff --git a/utils/v4l2-compliance/v4l2-compliance.cpp b/utils/v4l2-compliance/v4l2-compliance.cpp
> index 7169eefe..29475d6b 100644
> --- a/utils/v4l2-compliance/v4l2-compliance.cpp
> +++ b/utils/v4l2-compliance/v4l2-compliance.cpp
> @@ -968,7 +968,7 @@ err:
>  }
> 
>  void testNode(struct node &node, struct node &node_m2m_cap, struct node &expbuf_node, media_type type,
> -	      unsigned frame_count, unsigned all_fmt_frame_count)
> +	      unsigned frame_count, unsigned all_fmt_frame_count, int parent_media_fd)
>  {
>  	struct node node2;
>  	struct v4l2_capability vcap = {};
> @@ -997,8 +997,12 @@ void testNode(struct node &node, struct node &node_m2m_cap, struct node &expbuf_
>  		memset(&vcap, 0, sizeof(vcap));
>  	}
> 
> -	if (!node.is_media())
> -		media_fd = mi_get_media_fd(node.g_fd(), node.bus_info);
> +	if (!node.is_media()) {
> +		if (parent_media_fd >= 0)
> +			media_fd = parent_media_fd;
> +		else
> +			media_fd = mi_get_media_fd(node.g_fd(), node.bus_info);
> +	}
> 
>  	int fd = node.is_media() ? node.g_fd() : media_fd;
>  	if (fd >= 0) {
> diff --git a/utils/v4l2-compliance/v4l2-compliance.h b/utils/v4l2-compliance/v4l2-compliance.h
> index 7caf254b..c47f25f5 100644
> --- a/utils/v4l2-compliance/v4l2-compliance.h
> +++ b/utils/v4l2-compliance/v4l2-compliance.h
> @@ -308,7 +308,7 @@ int check_ustring(const __u8 *s, int len);
>  int check_0(const void *p, int len);
>  int restoreFormat(struct node *node);
>  void testNode(struct node &node, struct node &node_m2m_cap, struct node &expbuf_node, media_type type,
> -	      unsigned frame_count, unsigned all_fmt_frame_count);
> +	      unsigned frame_count, unsigned all_fmt_frame_count, int parent_media_fd = -1);
>  std::string stream_from(const std::string &pixelformat, bool &use_hdr);
> 
>  // Media Controller ioctl tests
> 

From the log, there is no change.

test log:
--------------------------------------------------------------------------------
Compliance test for device /dev/v4l-subdev1:

Driver Info:
	Driver version   : 6.6.0
	Capabilities     : 0x00000000

Required ioctls:
	test VIDIOC_SUDBEV_QUERYCAP: OK
	test invalid ioctls: OK

Allow for multiple opens:
	test second /dev/v4l-subdev1 open: OK
	test VIDIOC_SUBDEV_QUERYCAP: OK
	test for unlimited opens: OK

Debug ioctls:
	test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
	test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
	test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
	test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
	test VIDIOC_ENUMAUDIO: OK (Not Supported)
	test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
	test VIDIOC_G/S_AUDIO: OK (Not Supported)
	Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
	test VIDIOC_G/S_MODULATOR: OK (Not Supported)
	test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
	test VIDIOC_ENUMAUDOUT: OK (Not Supported)
	test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
	test VIDIOC_G/S_AUDOUT: OK (Not Supported)
	Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
	test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
	test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
	test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
	test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
	test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
	test VIDIOC_QUERYCTRL: OK
	test VIDIOC_G/S_CTRL: OK
	test VIDIOC_G/S/TRY_EXT_CTRLS: OK
	test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
	test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
	Standard Controls: 20 Private Controls: 0

Format ioctls:
	test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported)
	test VIDIOC_G/S_PARM: OK (Not Supported)
	test VIDIOC_G_FBUF: OK (Not Supported)
	test VIDIOC_G_FMT: OK (Not Supported)
	test VIDIOC_TRY_FMT: OK (Not Supported)
	test VIDIOC_S_FMT: OK (Not Supported)
	test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
	test Cropping: OK (Not Supported)
	test Composing: OK (Not Supported)
	test Scaling: OK (Not Supported)

Codec ioctls:
	test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
	test VIDIOC_G_ENC_INDEX: OK (Not Supported)
	test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
	test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported)
	test VIDIOC_EXPBUF: OK (Not Supported)
	test Requests: OK (Not Supported)

Total for device /dev/v4l-subdev1: 43, Succeeded: 43, Failed: 0, Warnings: 0

Grand Total for starfive-camss device /dev/media0: 201, Succeeded: 201, Failed: 0, Warnings: 0
# 

-- 
Regards,

Jack Zhu