From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Mayuresh Chitale <mchitale-qTEPVZfXA3Y@public.gmane.org>,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
patches-qTEPVZfXA3Y@public.gmane.org,
ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 3/4] arm64: dts: Add APM X-Gene PCIe DMA device tree nodes
Date: Wed, 07 Jan 2015 09:37:11 +0100 [thread overview]
Message-ID: <6884775.IcL8KCPQhi@wuerfel> (raw)
In-Reply-To: <1420608537-12296-4-git-send-email-mchitale-qTEPVZfXA3Y@public.gmane.org>
On Wednesday 07 January 2015 10:58:56 Mayuresh Chitale wrote:
>
> + xpdma0: dma0@1f2b0154 {
> + status = "disabled";
> + compatible = "apm,xgene-pciedma";
> + reg = < 0x0 0x1f2b0154 0x0 0xc
> + 0x0 0x1f2b0058 0x0 0x8>;
> + interrupts = <0x0 0xc6 0x4>;
> + };
> +
> + xpdma1: dma1@1f2c0154 {
> + status = "disabled";
> + compatible = "apm,xgene-pciedma";
> + reg = < 0x0 0x1f2c0154 0x0 0xc
> + 0x0 0x1f2c0058 0x0 0x8>;
> + interrupts = <0x0 0xcc 0x4>;
> + };
> +
>
Something's wrong here: you have the same addresses for
all the nodes but use different names. Please change the names
to all say 'dma' and set the correct addresses.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-07 8:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 5:28 [PATCH 0/4] APM X-Gene PCIe DMA driver Mayuresh Chitale
2015-01-07 5:28 ` [PATCH 1/4] MAINTAINERS: Add entry for X-Gene PCIE " Mayuresh Chitale
2015-01-07 5:28 ` [PATCH 2/4] Documentation: dt-bindings: Add the binding info for APM X-Gene PCIe " Mayuresh Chitale
2015-01-07 8:30 ` Arnd Bergmann
2015-01-07 10:42 ` Mayuresh Chitale
2015-01-07 5:28 ` [PATCH 3/4] arm64: dts: Add APM X-Gene PCIe DMA device tree nodes Mayuresh Chitale
[not found] ` <1420608537-12296-4-git-send-email-mchitale-qTEPVZfXA3Y@public.gmane.org>
2015-01-07 8:37 ` Arnd Bergmann [this message]
2015-01-07 10:45 ` Mayuresh Chitale
[not found] ` <CAL-zptPDU2qoot-aZMDwRmPQ_4QoCsqtQZ=kc-fN-Ts68qrVDQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-07 11:28 ` Arnd Bergmann
2015-01-07 5:28 ` [PATCH 4/4] dma: X-Gene PCIE DMA Driver Mayuresh Chitale
2015-01-07 8:35 ` Arnd Bergmann
2015-01-07 11:25 ` Mayuresh Chitale
2015-01-07 12:46 ` Arnd Bergmann
2015-01-07 16:05 ` Mayuresh Chitale
2015-01-07 16:22 ` Arnd Bergmann
2015-01-08 6:30 ` Mayuresh Chitale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6884775.IcL8KCPQhi@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mchitale-qTEPVZfXA3Y@public.gmane.org \
--cc=patches-qTEPVZfXA3Y@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox