From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F9CA3CF034 for ; Thu, 18 Jun 2026 07:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781767839; cv=none; b=LIE1S7LG2rOzVIzVw4cdB34td8i0Z6N6zXdblatBtC3k2VQ+jefXuo5s+/zOx3c4jltNL73ZWJ1EbMwzu+DIGJnTx3TmONLmEP6pauXMUttFtBdQxdHP0UFFH0dFDrVPZsigzRENIDiSZ5w10QWmOgSuM77K2NvlFEeAmf3oA7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781767839; c=relaxed/simple; bh=lFSwZvFzjtuAWeKjlsfzJCLORjJcZDSqREuzATpWvMY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZdxbWMArD5fFLj9Xy7/Y5lR4s6/86Bi7hmJk/oA0is/FaEnNyILCvC4QyAYOkaszUwOhUdMABizopRrHHrfCKu25EZyTzCLZ1N4O9bC22cIuDF1hmrZ0q5Rne+MCf7aGjJnoZ/a+13Vo5wepF5kBg1neMHIbk2rt/gVaVcCwJWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=qChns0vF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=X9Gd8nmb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=qChns0vF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=X9Gd8nmb; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="qChns0vF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="X9Gd8nmb"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="qChns0vF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="X9Gd8nmb" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 700306D170; Thu, 18 Jun 2026 07:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781767836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wd7ImIPthEOIDYLKO9h998HqbE/8DZRsM1nnMp2xSXA=; b=qChns0vFtoqRMvShCoRfrn0CV3n9LrD6h2dOLi0feu1caUZIy0MXYd5/PjQ9shHF+3R2AQ cW09FvH+4o4paLRMLzKYFDYDyEJELBPTnhgJKbxx5W7y3BOjKI6RnKK9AY5VVToQuno+8C A2hcJAjrMvGUJqJkwL+uhirf7+Zu1n4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781767836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wd7ImIPthEOIDYLKO9h998HqbE/8DZRsM1nnMp2xSXA=; b=X9Gd8nmbt1oDNBw/sW258yhDqwzbwzzR5E3mOdR4UjAqH0rf3RISqfvHykpcozx/iM7EIV uRdW62WSpOm2WXBA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781767836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wd7ImIPthEOIDYLKO9h998HqbE/8DZRsM1nnMp2xSXA=; b=qChns0vFtoqRMvShCoRfrn0CV3n9LrD6h2dOLi0feu1caUZIy0MXYd5/PjQ9shHF+3R2AQ cW09FvH+4o4paLRMLzKYFDYDyEJELBPTnhgJKbxx5W7y3BOjKI6RnKK9AY5VVToQuno+8C A2hcJAjrMvGUJqJkwL+uhirf7+Zu1n4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781767836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wd7ImIPthEOIDYLKO9h998HqbE/8DZRsM1nnMp2xSXA=; b=X9Gd8nmbt1oDNBw/sW258yhDqwzbwzzR5E3mOdR4UjAqH0rf3RISqfvHykpcozx/iM7EIV uRdW62WSpOm2WXBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0A129779A8; Thu, 18 Jun 2026 07:30:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ijVTAJyeM2qEdAAAD6G6ig (envelope-from ); Thu, 18 Jun 2026 07:30:36 +0000 Message-ID: <68a0c8de-9a12-4dc4-84ca-ae988b76087b@suse.de> Date: Thu, 18 Jun 2026 09:30:35 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] drm/tiny: add support for PIXPAPER 4.26 monochrome e-ink panel To: LiangCheng Wang , Devarsh Thakkar , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wig Cheng Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Tomi Valkeinen References: <20260529-bar-v3-0-5c2ac1c751ee@gmail.com> <20260529-bar-v3-2-5c2ac1c751ee@gmail.com> <9fb7915b-dc46-45af-bba1-a3d3a59b5e49@suse.de> <20260618023338.26630-1-zaq14760@gmail.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260618023338.26630-1-zaq14760@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TAGGED_RCPT(0.00)[dt]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[14]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_TO(0.00)[gmail.com,ti.com,linux.intel.com,kernel.org,ffwll.ch]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-Spam-Level: X-Spam-Score: -2.80 Hi Am 18.06.26 um 04:33 schrieb LiangCheng Wang: > Hi Thomas, > > Thanks for the review, and no worries about the timing. > > Before I spin a v4 for these comments, I'd like to confirm the overall > direction, since it affects whether this should remain a standalone driver > at all. > > In parallel, Devarsh Thakkar is adding a generic Solomon SSD16xx e-paper > driver (panel-ssd16xx.c, currently v1 in review). The PIXPAPER 4.26 uses an > SSD1677, which is part of that family; Devarsh has said he will add SSD1677 > support in the next revision (v2) of his series, after which this panel > could be supported there as a panel entry rather than as a separate driver. > That work isn't posted yet, but I had agreed that consolidating under > panel-ssd16xx.c is the better long-term direction. > > I'd appreciate your guidance on how to proceed -- whether it is better to > keep iterating on this standalone driver, or to hold it and add the > PIXPAPER 4.26 panel to panel-ssd16xx.c once that driver supports SSD1677. > I'm happy to go whichever way you prefer. I see. It is usually preferable to have only a single driver for a controller. If there are specific features of the Pixpaper 4.26, they should be added to the ssd16xx driver if possible. There are exceptions from this rule, of course. If the Pixpaper turns out to be significantly different, we can always reconsider. Best regards Thomas > > Regards, > LiangCheng -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)