From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Dikshita Agarwal <dikshita@codeaurora.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org,
stanimir.varbanov@linaro.org,
Mansur Alisha Shaik <mansur@codeaurora.org>
Subject: Re: [RESEND PATCH v6] arm64: dts: qcom: sc7280: Add venus DT node
Date: Fri, 22 Oct 2021 11:31:02 +0300 [thread overview]
Message-ID: <68a9da44-b568-85e9-6ec4-28fc8d95633f@linaro.org> (raw)
In-Reply-To: <YUpZaQ42ldzEKtV/@builder.lan>
Hi Dikshita,
On 9/22/21 1:15 AM, Bjorn Andersson wrote:
> On Mon 20 Sep 23:50 CDT 2021, Dikshita Agarwal wrote:
>
>> Add DT entries for the sc7280 venus encoder/decoder.
>>
>> this patch depends on [1].
>>
>> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=529463
Please drop those two lines above.
>
> The stuff you write here will be forever imprinted in the git history
> and it's already unnecessary, given that the patch you reference here is
> available in linux-next.
>
> Things you want to mention, but shouldn't go into the git history, put
> those below the '---' line.
>
>>
>> Co-developed-by: Mansur Alisha Shaik <mansur@codeaurora.org>
>> Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>
>> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
I guess this should be :
Co-developed-by: Mansur Alisha Shaik <mansur@codeaurora.org>
Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>
but checkpatch --strict should complain about this, no?
>> ---
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 75 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 75 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index a8c274a..f171ababc 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -63,6 +63,11 @@
>> no-map;
>> reg = <0x0 0x80b00000 0x0 0x100000>;
>> };
>> +
>> + video_mem: memory@8b200000 {
>> + reg = <0x0 0x8b200000 0x0 0x500000>;
>> + no-map;
>> + };
>> };
>>
>> cpus {
>> @@ -1063,6 +1068,76 @@
>> qcom,bcm-voters = <&apps_bcm_voter>;
>> };
>>
>> + venus: video-codec@aa00000 {
>> + compatible = "qcom,sc7280-venus";
>
> I do however now see this compatible defined in a binding in linux-next,
> so you definitely should have listed that patch as a dependency - and
> preferably held off sending me 6 versions (plus resend) of a patch that
> I can't merge.
>
> Please ping me once the binding is merged, so that I know when I can
> merge this patch.
Bjorn, the binding is in linux-next now.
--
--
regards,
Stan
prev parent reply other threads:[~2021-10-22 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 4:50 [RESEND PATCH v6] arm64: dts: qcom: sc7280: Add venus DT node Dikshita Agarwal
2021-09-21 22:15 ` Bjorn Andersson
2021-10-22 8:31 ` Stanimir Varbanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68a9da44-b568-85e9-6ec4-28fc8d95633f@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mansur@codeaurora.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).