From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE78C433EF for ; Fri, 22 Oct 2021 08:31:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 921476109E for ; Fri, 22 Oct 2021 08:31:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232125AbhJVIdX (ORCPT ); Fri, 22 Oct 2021 04:33:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231984AbhJVIdX (ORCPT ); Fri, 22 Oct 2021 04:33:23 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08131C061766 for ; Fri, 22 Oct 2021 01:31:06 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id r4so3886813edi.5 for ; Fri, 22 Oct 2021 01:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+s3RKjcGG+MOOi5e3FStCyMo3mus4CdAelMYmF9XjNI=; b=XA6b/fmmHaNPaJQ3RWZTTghGLmKtShh6KbyR2G7KJhw/Dx2kZN+ehZcl1lgX9u/iPM 3jf1s1h/0pRoiNYq7JNYf4RHU4Ew5+3dKl+rddx82JmMj887Yd0Qvhejhf/JTty8tIEV 655GZsYB1eyWoOPS9rEr7vTrFCdt6myHuW+zwyt2bYlIWSErX2wEDuiFkSxDNemfy5/p 7XwCzABaOuK0O1+c6vsIHnaH0YBrwdo7CukTK9IvEquCe3tVlpqi2NisDNYrOzddI71c F9Y/Dj0y1vw4P1gOLHkcY1+VFIFk2Rt5OSt0fZBlUmPagryhXyWfxo01DiTtVzXL9hR/ 2EEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+s3RKjcGG+MOOi5e3FStCyMo3mus4CdAelMYmF9XjNI=; b=uUoT62YHPdvABiK8k91QF6x8UMRi6slpg+N46joCsfI6+tjM/LZZCthEylJ6M+GOTN FSo2wi8t6hSGHH3tA709POSNBv6wmPELF36qTeUeEXwFiqCkWS233uQGzTxmg1YrlMxi z6elcJ4oIBwwo1AHFEwi6rLp9MYjVWibN4GASTxRpTOEBhRX40Sc2UJdo3VC5oPwsxZb OKE0gkp7Ui+3l3LH7fD5pQhqf71uz5cJ0o7Sqarhy5Tu3keMny4XC3ROcGZunPwjdZEo LBi2aPkdl/Z9Jye7vaOlTHRu4wjubLX337DXKt7mOFpSA0fisHSHFentgHh4tU9oex24 kBHg== X-Gm-Message-State: AOAM530lLsrrYI8R8FvPlGf1VKeIvVvJKHsgNfdKpWTPDMF+JzhX00Y9 43IMsT9cfK6Jg1pVfbafo3EuOw== X-Google-Smtp-Source: ABdhPJyjALlIYBx258q1rME3+PI/RUJSvPoCUA5pHFn2TnQwq1Dol04vdP1h5OJqKSklFppy+EzwbQ== X-Received: by 2002:a17:906:5805:: with SMTP id m5mr13683921ejq.221.1634891464458; Fri, 22 Oct 2021 01:31:04 -0700 (PDT) Received: from [192.168.1.15] (hst-221-79.medicom.bg. [84.238.221.79]) by smtp.googlemail.com with ESMTPSA id e7sm4448621edk.3.2021.10.22.01.31.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Oct 2021 01:31:03 -0700 (PDT) Subject: Re: [RESEND PATCH v6] arm64: dts: qcom: sc7280: Add venus DT node To: Bjorn Andersson , Dikshita Agarwal Cc: andy.gross@linaro.org, david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org, stanimir.varbanov@linaro.org, Mansur Alisha Shaik References: <1632199829-25686-1-git-send-email-dikshita@codeaurora.org> From: Stanimir Varbanov Message-ID: <68a9da44-b568-85e9-6ec4-28fc8d95633f@linaro.org> Date: Fri, 22 Oct 2021 11:31:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Dikshita, On 9/22/21 1:15 AM, Bjorn Andersson wrote: > On Mon 20 Sep 23:50 CDT 2021, Dikshita Agarwal wrote: > >> Add DT entries for the sc7280 venus encoder/decoder. >> >> this patch depends on [1]. >> >> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=529463 Please drop those two lines above. > > The stuff you write here will be forever imprinted in the git history > and it's already unnecessary, given that the patch you reference here is > available in linux-next. > > Things you want to mention, but shouldn't go into the git history, put > those below the '---' line. > >> >> Co-developed-by: Mansur Alisha Shaik >> Signed-off-by: Dikshita Agarwal >> Signed-off-by: Mansur Alisha Shaik I guess this should be : Co-developed-by: Mansur Alisha Shaik Signed-off-by: Mansur Alisha Shaik Signed-off-by: Dikshita Agarwal but checkpatch --strict should complain about this, no? >> --- >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 75 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 75 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index a8c274a..f171ababc 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> @@ -63,6 +63,11 @@ >> no-map; >> reg = <0x0 0x80b00000 0x0 0x100000>; >> }; >> + >> + video_mem: memory@8b200000 { >> + reg = <0x0 0x8b200000 0x0 0x500000>; >> + no-map; >> + }; >> }; >> >> cpus { >> @@ -1063,6 +1068,76 @@ >> qcom,bcm-voters = <&apps_bcm_voter>; >> }; >> >> + venus: video-codec@aa00000 { >> + compatible = "qcom,sc7280-venus"; > > I do however now see this compatible defined in a binding in linux-next, > so you definitely should have listed that patch as a dependency - and > preferably held off sending me 6 versions (plus resend) of a patch that > I can't merge. > > Please ping me once the binding is merged, so that I know when I can > merge this patch. Bjorn, the binding is in linux-next now. -- -- regards, Stan