From: Krzysztof Kozlowski <krzk@kernel.org>
To: Eddie James <eajames@linux.ibm.com>, linux-aspeed@lists.ozlabs.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andrew@codeconstruct.com.au, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: hwmon: ucd90320: Add 90160 compatible
Date: Thu, 20 Feb 2025 19:05:05 +0100 [thread overview]
Message-ID: <68c61ffc-51c7-48a4-9fba-a14562d0027d@kernel.org> (raw)
In-Reply-To: <f9615bfa-9d3a-47df-a5dc-a6a1f3b4940b@linux.ibm.com>
On 20/02/2025 17:15, Eddie James wrote:
>
> On 2/20/25 08:47, Krzysztof Kozlowski wrote:
>> On 19/02/2025 22:27, Eddie James wrote:
>>> The 90160 is just like the 90320 but with less GPIs and GPIOs.
>> Then isn't it compatible?
>>
>> Where is your driver change?
>
>
> Sorry, my commit message should be more clear. The driver already
> supports the ucd90160 and matches the compatible string I added here.
> I'll improve my commit message for v2.
Driver has many more entries, why are you adding only one compatible?
Please fix all of them, not one by one.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-20 18:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 21:27 [PATCH 0/3] ARM: dts: aspeed: Add Balcones system Eddie James
2025-02-19 21:27 ` [PATCH 1/3] dt-bindings: arm: aspeed: add IBM Balcones board Eddie James
2025-02-20 14:46 ` Krzysztof Kozlowski
2025-02-19 21:27 ` [PATCH 2/3] dt-bindings: hwmon: ucd90320: Add 90160 compatible Eddie James
2025-02-20 14:47 ` Krzysztof Kozlowski
2025-02-20 16:15 ` Eddie James
2025-02-20 18:05 ` Krzysztof Kozlowski [this message]
2025-02-19 21:27 ` [PATCH 3/3] ARM: dts: aspeed: Add Balcones system Eddie James
2025-02-20 0:41 ` Andrew Jeffery
2025-02-20 14:36 ` Eddie James
2025-02-20 21:29 ` [PATCH 0/3] " Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68c61ffc-51c7-48a4-9fba-a14562d0027d@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).