From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B751C6FD18 for ; Tue, 25 Apr 2023 08:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232661AbjDYIT0 (ORCPT ); Tue, 25 Apr 2023 04:19:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231175AbjDYITZ (ORCPT ); Tue, 25 Apr 2023 04:19:25 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AFA340DF for ; Tue, 25 Apr 2023 01:19:21 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-95316faa3a8so1011771566b.2 for ; Tue, 25 Apr 2023 01:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682410759; x=1685002759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=znRV0nWYnqPOSY77B900qlMay8TPNkGb3s+FapEpgN0=; b=LrmBxu2EGogQSTBkcCYzasNpZW/pKKd+LqTsGa/ifcmlV7SrWEsRCLujLGcNA137kR lgwXt02NGHCJSzACgRty3LrKWmIf7PuMckGMm8d0LuQHfa3kRMdEE7xcneEgoDnt30pU ICbLRprS81Q5+UWB1qUS+Xz8ejauuXRB00g3emna+Fc5Uq0YzQKXiO1HCgOSVUYsofLg HAyRSdTObW2jp7yFUero1cT0zWgI5o8AgwOUvzA7wvYF/P5Igdaa8PA9CIAotIyyWhPE HQyi2HqeCP3YbfrWZ9wHHbqpVkFD2C3LQt4yqEcG14S1CGYcQHSyqFmpM6tPjofJhhJ9 MN3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682410759; x=1685002759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=znRV0nWYnqPOSY77B900qlMay8TPNkGb3s+FapEpgN0=; b=jHguj+KocDb+9OI/QnS/llnTZO2KVNQHJEy48vQPHXope7UFe/vncRhl2hxJRk5z4q Mk4eK0BgdoxD6gKBoPjm/Hu2yEKdYiP9zuB8rv3B6VoxSBwn0WmE4wKUQLStp9Uz+Nmd sGg65CYPLB6Il2REYV+DaBgbF+A62QKEfuDfksbvgGsI9B2jtqszZhWWfqv2rA5/OLmJ 57aARghMf5QiZu9z0nL331r+JaLg4FfoJHSi9/61BLUL30G5UfGCcYXr0xi3vEkeiLMg 5pH4YBI9a95eQmS8PAXx10v7gXjxKGAcbuoTGEisw5O6yxQeDZUI0Ib8H9z2LXtymwwo cSOA== X-Gm-Message-State: AAQBX9eCrl5iUieN+hjF/PXi54wyAR7n3JkSlScRksxRE0RUvLJr8un2 +BzsC/rKjhwt0yOhO4SirlU10w== X-Google-Smtp-Source: AKy350baIrrRrmfaPcUDOSj2l2OdIXPrZ1RbEUf1vTKFBK8BjYDz6c/Q0be38k6esdo6bxwhgxnskg== X-Received: by 2002:a17:907:76ea:b0:94f:7486:85a7 with SMTP id kg10-20020a17090776ea00b0094f748685a7mr12083094ejc.31.1682410759554; Tue, 25 Apr 2023 01:19:19 -0700 (PDT) Received: from [192.168.9.102] ([195.167.132.10]) by smtp.gmail.com with ESMTPSA id la5-20020a170906ad8500b0094e877ec197sm6587131ejb.148.2023.04.25.01.19.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 01:19:18 -0700 (PDT) Message-ID: <68cb565d-bf39-10b0-9e3e-35ba7f54b90b@linaro.org> Date: Tue, 25 Apr 2023 10:19:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support Content-Language: en-US To: Changhuang Liang , Conor Dooley Cc: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, vkoul@kernel.org, linux-phy@lists.infradead.org References: <20230419035646.43702-1-changhuang.liang@starfivetech.com> <20230419035646.43702-2-changhuang.liang@starfivetech.com> <20230419-labored-camper-644d51a7ca96@spud> <1a5b15fa-4f20-51c2-2ba1-a04a2911a694@starfivetech.com> <20230424-baffle-punch-ec73098f2b6a@spud> <20230425-unquote-eligible-09f743d81981@wendy> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/04/2023 09:57, Changhuang Liang wrote: >>>>>>> >>>>>>> description: | >>>>>>> StarFive JH7110 SoC includes support for multiple power domains which can be >>>>>>> @@ -17,6 +18,7 @@ properties: >>>>>>> compatible: >>>>>>> enum: >>>>>>> - starfive,jh7110-pmu >>>>>>> + - starfive,jh7110-aon-pmu >>>> >>>> I was speaking to Rob about this over the weekend, he asked: >>>> 'Why isn't "starfive,jh7110-aon-syscon" just the power-domain provider >>>> itself?' >>> >>> Maybe not, this syscon only offset "0x00" configure power switch. >>> other offset configure other functions, maybe not power, so this >>> "starfive,jh7110-aon-syscon" not the power-domain itself. >>> >>>> Do we actually need to add a new binding for this at all? >>>> >>>> Cheers, >>>> Conor. >>>> >>> >>> Maybe this patch do that. >>> https://lore.kernel.org/all/20230414024157.53203-6-xingyu.wu@starfivetech.com/ >> >> This makes it a child-node right? I think Rob already said no to that in >> and earlier revision of this series. What he meant the other day was >> making the syscon itself a power domain controller, since the child node >> has no meaningful properties (reg, interrupts etc). >> >> Cheers, >> Conor. > > Yes, "starfive,jh7110-aon-pmu" is a child-node of "starfive,jh7110-aon-syscon". > In my opinion, "0x17010000" is "aon-syscon" on JH7110 SoC, and this "aon-pmu" is just > a part of "aon-syscon" function, so I think it is inappropriate to make "aon-syscon" > to a power domain controller. I think using the child-node description is closer to > JH7110 SoC. Unfortunately, I do not see the correlation between these, any connection. Why being a child of syscon block would mean that this should no be power domain controller? Really, why? These are two unrelated things. Best regards, Krzysztof