public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	robh+dt@kernel.org, plagnioj@jcrosoft.com, airlied@linux.ie,
	thierry.reding@gmail.com
Cc: daniel.vetter@ffwll.ch, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: display: display-timing: Add property to configure sync drive edge
Date: Thu, 29 Sep 2016 13:52:51 +0300	[thread overview]
Message-ID: <68e2ba2d-90e6-d8c9-3595-cf566b18923e@ti.com> (raw)
In-Reply-To: <20160922103526.24925-2-peter.ujfalusi@ti.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1805 bytes --]

On 22/09/16 13:35, Peter Ujfalusi wrote:
> There are display panels which demands that the sync signal is driven on
> different edge than the pixel data.
> With the syncclk-active property we can specify the clk edge to be used to
> drive the sync signal. When the property is missing it indicates that the
> sync is driven on the same edge as the pixel data.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> CC: Rob Herring <robh+dt@kernel.org>
> CC: Mark Rutland <mark.rutland@arm.com>
> CC: devicetree@vger.kernel.org
> ---
>  .../devicetree/bindings/display/panel/display-timing.txt          | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/display-timing.txt b/Documentation/devicetree/bindings/display/panel/display-timing.txt
> index e1d4a0b59612..81a75893d1b8 100644
> --- a/Documentation/devicetree/bindings/display/panel/display-timing.txt
> +++ b/Documentation/devicetree/bindings/display/panel/display-timing.txt
> @@ -32,6 +32,14 @@ optional properties:
>  			- active low  = drive pixel data on falling edge/
>  					sample data on rising edge
>  			- ignored     = ignored
> + - syncclk-active: with
> +			- active high = drive sync on rising edge/
> +					sample sync on falling edge of pixel
> +					clock
> +			- active low  = drive sync on falling edge/
> +					sample sync on rising edge of pixel
> +					clock
> +			- omitted     = same configuration as pixelclk-active

I wonder if the "sample sync on..." should be left out here. It makes
sense for the pixel data, but for sync... Do the panels "sample" it, or
do they trigger on rising/falling edge?

Well, maybe that's a bit on the nitpick side, so:

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

 Tomi


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-09-29 10:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 10:35 [PATCH v2 0/3] video: of: Drive edge selection for sync Peter Ujfalusi
     [not found] ` <20160922103526.24925-1-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2016-09-22 10:35   ` [PATCH v2 1/3] dt-bindings: display: display-timing: Add property to configure sync drive edge Peter Ujfalusi
     [not found]     ` <20160922103526.24925-2-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2016-09-23 20:01       ` Rob Herring
2016-09-29 10:52     ` Tomi Valkeinen [this message]
2016-09-22 10:35   ` [PATCH v2 3/3] video: of: display_timing: Add support for syncclk-active property Peter Ujfalusi
2016-09-29 10:55     ` Tomi Valkeinen
2016-09-22 10:35 ` [PATCH v2 2/3] video: display_timing: Add flags to select the edge when the sync is driven Peter Ujfalusi
     [not found]   ` <20160922103526.24925-3-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2016-09-29 10:54     ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68e2ba2d-90e6-d8c9-3595-cf566b18923e@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox