Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

Maxime Ripard
2019-06-04T14:59:07Z

[-- Attachment #1: Type: text/plain, Size: 2046 bytes --]

Hi Luca,

On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote:
> Add a node describing the KEYADC on the A64.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>

You should have a changelog detailing which changes you made to your
patch with the previous version, and why you made those changes (for
example because we looked at the a83t datasheet and found the two
controllers to be very similar).

> ---
> .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 +
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> index 496125c6bfb7..507b737612ea 100644
> --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
> @@ -5,6 +5,7 @@ Required properties:
> - compatible: should be one of the following string:
> "allwinner,sun4i-a10-lradc-keys"
> "allwinner,sun8i-a83t-r-lradc"
> + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc"
> - reg: mmio address range of the chip
> - interrupts: interrupt to which the chip is connected
> - vref-supply: powersupply for the lradc reference voltage
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 7734f70e1057..3a42352b5c9f 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -704,6 +704,14 @@
> status = "disabled";
> };
>
> + lradc: lradc@1c21800 {
> + compatible = "allwinner,sun50i-a64-lradc",
> + "allwinner,sun8i-a83t-r-lradc";
> + reg = <0x01c21800 0x400>;
> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> +

The bindings and the dt changes should be two different patches as
well.

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]