devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: Jim Davis <jim.epost@gmail.com>,
	sfr@canb.auug.org.au, linux-next <linux-next@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	sbkim73@samsung.com, sameo@linux.intel.com,
	grant.likely@linaro.org, robh+dt@kernel.org,
	devicetree <devicetree@vger.kernel.org>
Subject: mfd: sec-core requires regulators
Date: Tue, 24 Jun 2014 20:09:07 +0200	[thread overview]
Message-ID: <6906564.1ehoeq1QjB@wuerfel> (raw)
In-Reply-To: <20140624154833.GR13803@lee--X1>

The newly added sec-core mfd module calls the regulator_suspend_prepare()
function, which is only available if the regulator API is provided. This
matches the usage of the driver, so we can just add a Kconfig dependency.

Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 207c433..1caa3c5 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -582,7 +582,7 @@ config MFD_RC5T583
 
 config MFD_SEC_CORE
        bool "SAMSUNG Electronics PMIC Series Support"
-       depends on I2C=y
+       depends on I2C=y && REGULATOR
        select MFD_CORE
        select REGMAP_I2C
        select REGMAP_IRQ

  reply	other threads:[~2014-06-24 18:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 14:39 randconfig build error with next-20140624, in drivers/mfd/sec-core.c Jim Davis
2014-06-24 14:57 ` Arnd Bergmann
2014-06-24 15:48   ` Lee Jones
2014-06-24 18:09     ` Arnd Bergmann [this message]
2014-06-27  9:09       ` mfd: sec-core requires regulators Lee Jones
2014-06-27 10:19         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6906564.1ehoeq1QjB@wuerfel \
    --to=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=jim.epost@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=sbkim73@samsung.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).