From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>,
dbaryshkov@gmail.com, dwmw2@infradead.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
santosh.shilimkar@ti.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, grygorii.strashko@ti.com,
linux@arm.linux.org.uk, linux-doc@vger.kernel.org,
w-kwok2@ti.com, rdunlap@infradead.org, sboyd@codeaurora.org,
linux-kernel@vger.kernel.org, olof@lixom.net
Subject: Re: [PATCH v2 2/5] Power: reset: add bindings for keystone reset driver
Date: Mon, 14 Apr 2014 20:44:32 +0200 [thread overview]
Message-ID: <6937937.4J6iI7VpBO@wuerfel> (raw)
In-Reply-To: <1397497283-16391-3-git-send-email-ivan.khoronzhuk@ti.com>
On Monday 14 April 2014 20:41:20 Ivan Khoronzhuk wrote:
> +Optional properties:
> +
> +- ti,soft-reset: Boolean option indicating soft reset.
> + By default hard reset is used.
> +
> +- ti,wdt_list: WDT list that can cause SoC reset.
> + The list in format: <0>, <2>;
> + Begins from 0 to 3, as keystone can contain up
> + to 4 SoC reset watchdogs.
>
This looks like your binding just describes a subset of the
watchdog timer registers. If so, don't do a standalone reset
driver, but instead do a watchdog driver that can also be
used for reset, and have a binding that properly describes
the watchdog hardware.
It is bad to have overlapping register ranges between logical
devices, and it's also generally wrong to describe devices that
are not actually there: The hardware contains a watchdog, not
a system-reset device, so you should not make one up because
it seems easier given the Linux driver model.
Arnd
next prev parent reply other threads:[~2014-04-14 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 17:41 [PATCH v2 0/5] Introduce keystone reset driver Ivan Khoronzhuk
2014-04-14 17:41 ` [PATCH v2 1/5] Power: reset: keystone-reset: introduce " Ivan Khoronzhuk
2014-04-14 17:41 ` [PATCH v2 2/5] Power: reset: add bindings for " Ivan Khoronzhuk
2014-04-14 18:44 ` Arnd Bergmann [this message]
2014-04-15 11:25 ` Ivan Khoronzhuk
2014-05-05 18:53 ` Ivan Khoronzhuk
2014-04-14 17:41 ` [PATCH v2 3/5] ARM: keystone: remove redundant reset stuff Ivan Khoronzhuk
2014-04-14 17:41 ` [PATCH v2 4/5] ARM: dts: keystone: update reset node to work with reset driver Ivan Khoronzhuk
2014-04-14 17:41 ` [PATCH v2 5/5] ARM: keystone: enable reset driver support Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6937937.4J6iI7VpBO@wuerfel \
--to=arnd@arndb.de \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.khoronzhuk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=sboyd@codeaurora.org \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox