From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>,
Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Benjamin Li <benl@squareup.com>
Subject: Re: [PATCH 5/8] arm64: dts: qcom: msm8939: Fix regulator constraints
Date: Wed, 14 Jun 2023 13:48:47 +0100 [thread overview]
Message-ID: <694a8e47-b478-7ca3-006b-b0972bf7e0a6@linaro.org> (raw)
In-Reply-To: <20230530-msm8939-regulators-v1-5-a3c3ac833567@gerhold.net>
On 14/06/2023 08:16, Stephan Gerhold wrote:
> The regulator constraints for the MSM8939 devices were originally taken
> from Qualcomm's msm-3.10 vendor device tree (for lack of better
> documentation). Unfortunately it turns out that Qualcomm's voltages are
> slightly off as well and do not match the voltage constraints applied
> by the RPM firmware.
>
> This means that we sometimes request a specific voltage but the RPM
> firmware actually applies a much lower or higher voltage. This is
> particularly critical for pm8916_l11 which is used as SD card VMMC
> regulator: The SD card can choose a voltage from the current range of
> 1.8 - 2.95V. If it chooses to run at 1.8V we pretend that this is fine
> but the RPM firmware will still silently end up configuring 2.95V.
> This can be easily reproduced with a multimeter or by checking the
> SPMI hardware registers of the regulator.
>
> Apply the same change as for MSM8916 in commit 355750828c55 ("arm64:
> dts: qcom: msm8916: Fix regulator constraints") and make the voltages
> match the actual "specified range" in the PM8916 Device Specification
> which is enforced by the RPM firmware.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Hrmm.
I recently found in the schematic the following table.
Supply | Default V | Range V | Rated I | Default On
L1 1.2875 0.375-1.525 250 N
L2 1.2 0.375.1.525 600 Y
L3 1.15 0.375-1.525 350 Y
L4 2.05 1.75-3.337 250 N
L5 1.8 1.75-3.337 200 Y
L6 1.8 1.75-3.337 150 Y
L7 1.8 1.75-3.337 110 Y
L8 2.9 1.75-3.337 400 Y
L9 3.3 1.75-3.337 600 N
L10 2.8 1.75-3.337 150 N
L11 2.95 1.75-3.337 600 Y
L12 2.95 1.75-3.337 50 Y
L13 3.075 1.75-3.337 50 Y
L14 1.8 1.75-3.337 55 N
L15 1.8 1.75-3.337 55 N
L16 1.8 1.75-3.337 55 N
L17 2.85 1.75-3.337 450 N
L18 2.7 1.75-3.337 150 N
So let me see.
L8 2.9 = true
L11 2.95 = true
S3 just says 1v3 but, I take your word for it on the multi-meter
measurement.
S4 says 2v1
This patch looks fine
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2023-06-14 12:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 7:15 [PATCH 0/8] arm64: dts: qcom: msm8939: Rework regulator constraints Stephan Gerhold
2023-06-14 7:15 ` [PATCH 1/8] arm64: dts: qcom: msm8939-pm8916: Add missing pm8916_codec supplies Stephan Gerhold
2023-06-14 12:23 ` Bryan O'Donoghue
2023-06-14 7:16 ` [PATCH 2/8] arm64: dts: qcom: msm8939: Disable lpass_codec by default Stephan Gerhold
2023-06-14 12:25 ` Bryan O'Donoghue
2023-06-14 7:16 ` [PATCH 3/8] arm64: dts: qcom: msm8939-sony-tulip: Fix l10-l12 regulator voltages Stephan Gerhold
2023-06-14 12:26 ` Bryan O'Donoghue
2023-06-14 7:16 ` [PATCH 4/8] arm64: dts: qcom: msm8939-sony-tulip: Allow disabling pm8916_l6 Stephan Gerhold
2023-06-14 12:26 ` Bryan O'Donoghue
2023-06-14 7:16 ` [PATCH 5/8] arm64: dts: qcom: msm8939: Fix regulator constraints Stephan Gerhold
2023-06-14 12:48 ` Bryan O'Donoghue [this message]
2023-06-14 7:16 ` [PATCH 6/8] arm64: dts: qcom: msm8939-pm8916: Clarify purpose Stephan Gerhold
2023-06-14 7:16 ` [PATCH 7/8] arm64: dts: qcom: msm8939: Define regulator constraints next to usage Stephan Gerhold
2023-06-14 12:51 ` Bryan O'Donoghue
2023-06-14 7:16 ` [PATCH 8/8] arm64: dts: qcom: msm8939-pm8916: Mark always-on regulators Stephan Gerhold
2023-06-14 16:03 ` [PATCH 0/8] arm64: dts: qcom: msm8939: Rework regulator constraints Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=694a8e47-b478-7ca3-006b-b0972bf7e0a6@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benl@squareup.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).