From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B65C433DF for ; Thu, 23 Jul 2020 08:27:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FB2520768 for ; Thu, 23 Jul 2020 08:27:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbgGWI1W (ORCPT ); Thu, 23 Jul 2020 04:27:22 -0400 Received: from gloria.sntech.de ([185.11.138.130]:52126 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbgGWI1V (ORCPT ); Thu, 23 Jul 2020 04:27:21 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyWZP-0000Xo-ET; Thu, 23 Jul 2020 10:27:15 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Jagan Teki Cc: Rob Herring , Suniel Mahesh , Michael Trimarchi , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , devicetree , linux-kernel , linux-amarula Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding Date: Thu, 23 Jul 2020 10:27:14 +0200 Message-ID: <6968987.cG2su2sgyb@diego> In-Reply-To: References: <20200722190949.215656-1-jagan@amarulasolutions.com> <3893924.cuH9TW0V3R@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Donnerstag, 23. Juli 2020, 08:34:12 CEST schrieb Jagan Teki: > Hi Heiko, > > On Thu, Jul 23, 2020 at 4:43 AM Heiko Stuebner wrote: > > > > Hi Jagan, > > > > Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki: > > > Add dt-bindings for ROCKPi 4B which is similar to 4A with > > > additional AP6256 Wifi/BT, PoE. > > > > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v2: > > > - new patch > > > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > index 36057c9e4b83..7250adb43d24 100644 > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > @@ -448,6 +448,12 @@ properties: > > > - const: radxa,rockpi4a > > > - const: rockchip,rk3399 > > > > > > + - description: Radxa ROCK Pi 4B > > > + items: > > > + - const: radxa,rockpi4 > > > + - const: radxa,rockpi4b > > > + - const: rockchip,rk3399 > > > + > > > > Please do all RockPi4 variants into one entry, so we want something like: > > > > - description: Radxa ROCK Pi 4 > > What if the description has something like below. > > - description: Radxa ROCK Pi 4A/B/C That's also ok :-)