Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Henrik Grimler <henrik@grimler.se>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties
Date: Wed, 31 Jan 2024 09:32:47 +0100	[thread overview]
Message-ID: <69783a3d-a158-4582-93d2-3f120e2e9ea6@linaro.org> (raw)
In-Reply-To: <20240131082401.GA6710@samsung-a5>

On 31/01/2024 09:25, Henrik Grimler wrote:
> Hi Krzysztof,
> 
> On Wed, Jan 31, 2024 at 08:19:39AM +0100, Krzysztof Kozlowski wrote:
>> On 30/01/2024 21:40, Henrik Grimler wrote:
>>> Sort all node properties according to dts coding style guidelines, to
>>> make dtsi easier to follow.
>>>
>>> Signed-off-by: Henrik Grimler <henrik@grimler.se>
>>> ---
>>>  .../dts/samsung/exynos5420-galaxy-tab-common.dtsi  | 23 +++++++++++-----------
>>>  1 file changed, 11 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> index f525b2f5e4e0..0c1aeafc025b 100644
>>> --- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> +++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> @@ -103,8 +103,8 @@ &cpu4 {
>>>  };
>>>  
>>>  &gpu {
>>> -	status = "okay";
>>>  	mali-supply = <&buck4_reg>;
>>> +	status = "okay";
>>
>> Such changes should come from a tool, but since we do not have them, I
>> don't want to bother with properties re-shuffling.
> 
> Noted, thanks. I will drop this patch and send a v2 in a few hours.

No need for v2, unless some other comments pop up. I will just apply #2
and #3 from this set.

Best regards,
Krzysztof


  reply	other threads:[~2024-01-31  8:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 20:40 [PATCH 0/3] ARM: dts: samsung: enable wifi and cleanup exynos5420-galaxy-tab dts'es Henrik Grimler
2024-01-30 20:40 ` [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties Henrik Grimler
2024-01-31  7:19   ` Krzysztof Kozlowski
2024-01-31  8:25     ` Henrik Grimler
2024-01-31  8:32       ` Krzysztof Kozlowski [this message]
2024-01-30 20:40 ` [PATCH 2/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: add wifi node Henrik Grimler
2024-02-06 10:16   ` Krzysztof Kozlowski
2024-01-30 20:40 ` [PATCH 3/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: decrease available memory Henrik Grimler
2024-02-06 10:17   ` (subset) " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69783a3d-a158-4582-93d2-3f120e2e9ea6@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=henrik@grimler.se \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox