From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: net: nxp,sja1105: document spi-cpol/cpha
Date: Thu, 3 Nov 2022 21:44:36 -0400 [thread overview]
Message-ID: <698c3a72-f694-01ac-80ba-13bd40bb6534@linaro.org> (raw)
In-Reply-To: <20221103233319.m2wq5o2w3ccvw5cu@skbuf>
On 03/11/2022 19:33, Vladimir Oltean wrote:
> Hi Krzysztof,
>
> On Wed, Nov 02, 2022 at 02:52:32PM -0400, Krzysztof Kozlowski wrote:
>> Some boards use SJA1105 Ethernet Switch with SPI CPOL and CPHA, so
>> document this to fix dtbs_check warnings:
>>
>> arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb: ethernet-switch@0: Unevaluated properties are not allowed ('spi-cpol' was unexpected)
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Changes since v1:
>> 1. Add also cpha
>> ---
>> Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
>> index 1e26d876d146..3debbf0f3789 100644
>> --- a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
>> +++ b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
>> @@ -36,6 +36,9 @@ properties:
>> reg:
>> maxItems: 1
>>
>> + spi-cpha: true
>> + spi-cpol: true
>> +
>> # Optional container node for the 2 internal MDIO buses of the SJA1110
>> # (one for the internal 100base-T1 PHYs and the other for the single
>> # 100base-TX PHY). The "reg" property does not have physical significance.
>> --
>> 2.34.1
>>
>
> Don't these belong to spi-peripheral-props.yaml?
No, they are device specific, not controller specific. Every device
requiring them must explicitly include them.
See:
https://lore.kernel.org/all/20220816124321.67817-1-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-04 1:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 18:52 [PATCH v2] dt-bindings: net: nxp,sja1105: document spi-cpol/cpha Krzysztof Kozlowski
2022-11-03 23:33 ` Vladimir Oltean
2022-11-04 1:44 ` Krzysztof Kozlowski [this message]
2022-11-04 2:03 ` Vladimir Oltean
2022-11-04 13:09 ` Krzysztof Kozlowski
2022-11-04 16:52 ` Vladimir Oltean
2022-11-04 17:13 ` Krzysztof Kozlowski
2022-11-04 17:31 ` Vladimir Oltean
2022-11-04 17:00 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=698c3a72-f694-01ac-80ba-13bd40bb6534@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).