From: "Sagar Dharia" <sdharia@codeaurora.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Sagar Dharia <sdharia@codeaurora.org>,
davidb@codeaurora.org, bryanh@codeaurora.org,
kheitke@codeaurora.org, gclemson@audience.com,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, rob@landley.net,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
ohad@wizery.com, gregkh@linuxfoundation.org,
linus.walleij@linaro.org, rusty@rustcorp.com.au,
joerg.roedel@amd.com, trenn@suse.de, ak@linux.intel.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] slimbus: Linux driver framework for SLIMbus.
Date: Mon, 4 Jun 2012 03:36:55 -0700 (PDT) [thread overview]
Message-ID: <69926c6ce4b1e004069662fb13287e9b.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <20120604102747.GC7538@opensource.wolfsonmicro.com>
>> While taking care of the comments for RFC, I have introduced a
>> completion
>> that will be signalled when LA is given to the device. The driver can
>> wait
>> on that completion (wait_enum) instead of polling.
>
> This would mean that the thread the probe is happening in will be
> blocked until the LA is assigned. That sounds like it might cause
> problems, either slowing things down or worst case causing a deadlock.
>
I would expect that the slim_device's driver will only power-on the device
during probe (and use wait_for_completion during 1st transfer to get LA).
Typically transfers are not done as part of probe. Even if transfers need
to be done as part of probe, I expect wait_for_completion (with timeout to
avoid potential HW problems causing linux probe to wait forever) will be
better than polling for get_logical_addr.
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-06-04 10:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 1:11 [PATCH] slimbus: Linux driver framework for SLIMbus Sagar Dharia
2012-05-30 18:13 ` Mark Brown
2012-06-04 9:54 ` Sagar Dharia
2012-06-01 0:16 ` Marc Butler
2012-06-04 10:21 ` Sagar Dharia
2012-06-04 10:27 ` Mark Brown
2012-06-04 10:36 ` Sagar Dharia [this message]
2012-06-04 10:42 ` Mark Brown
2012-06-04 17:13 ` Marc Butler
2012-06-06 8:13 ` Sagar Dharia
[not found] ` <1338340310-4473-1-git-send-email-sdharia-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-06-03 16:34 ` Joe Perches
2012-06-04 10:25 ` Sagar Dharia
2012-06-04 3:14 ` Rob Landley
2012-06-04 7:29 ` Mark Brown
2012-06-04 9:51 ` Sagar Dharia
2012-06-04 23:41 ` Ryan Mallon
2012-06-06 8:19 ` Sagar Dharia
2012-06-05 20:57 ` Marc Butler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69926c6ce4b1e004069662fb13287e9b.squirrel@www.codeaurora.org \
--to=sdharia@codeaurora.org \
--cc=ak@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gclemson@audience.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=joerg.roedel@amd.com \
--cc=kheitke@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rusty@rustcorp.com.au \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).