From: Anilkumar Kolli <akolli@codeaurora.org>
To: Sven Eckelmann <sven@narfation.org>
Cc: ath11k@lists.infradead.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org
Subject: Re: [PATCH v4 2/2] ath11k: Use reserved host DDR addresses from DT for PCI devices
Date: Tue, 23 Nov 2021 16:09:21 +0530 [thread overview]
Message-ID: <69b243375da1358f39955186fb69a55d@codeaurora.org> (raw)
In-Reply-To: <2802525.9g7TWp2vRq@ripper>
On 2021-11-22 13:20, Sven Eckelmann wrote:
> On Monday, 22 November 2021 07:12:27 CET Anilkumar Kolli wrote:
> [...]
>> >> + start = reg[0] + reg[1];
>> >> + size = reg[2] + reg[3];
>> >
>> > See my messages for v2 [1] and v3 [2]
>> >
>> >
>> Thanks for the review,
>>
>> Here addresses are always within 32-bit.
>> so I will change the API to read only 2 integers and update start
>> addresss and size.
>
> The size of address and size depends on the reserved-memory node - not
> the
> qcn9074 node. So please don't make such assumptions in your code.
>
Yes, correct.
of_address_to_resource() returns start/end address properly.
I will update and send next version.
- Anil.
prev parent reply other threads:[~2021-11-23 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 14:22 [PATCH v4 1/2] dt: bindings: add new DT entry for ath11k PCI device support Anilkumar Kolli
2021-11-21 14:22 ` [PATCH v4 2/2] ath11k: Use reserved host DDR addresses from DT for PCI devices Anilkumar Kolli
2021-11-21 14:45 ` Sven Eckelmann
2021-11-22 6:12 ` Anilkumar Kolli
2021-11-22 7:50 ` Sven Eckelmann
2021-11-23 10:39 ` Anilkumar Kolli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69b243375da1358f39955186fb69a55d@codeaurora.org \
--to=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).