From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4337C47089 for ; Thu, 27 May 2021 01:28:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9A11613D3 for ; Thu, 27 May 2021 01:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234456AbhE0B36 (ORCPT ); Wed, 26 May 2021 21:29:58 -0400 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:55313 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232861AbhE0B36 (ORCPT ); Wed, 26 May 2021 21:29:58 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id CC55C5805E5; Wed, 26 May 2021 21:28:25 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 26 May 2021 21:28:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=QugCToE2oD/Akw5181hdEz10jkbZriJ +fq6eWbXxrco=; b=ShbfusHb2jQRdrZ4WtIJPdk34pieGO5nJI88/AnOM1NrEXH mxxVr739gJoOcnpgcIfvGpavhJ/rzH5ynFWmziD7Sdd9QEM60CPQUyjthUscd+Ao g5WJHjn6UVVrks0qs9h75p03IhEKNRhQBJ0zw8tRsbazhaNPG1ZwSVefr7WRPzAW ZkcOtX4oAIa/YJEm+VlRkaMtu12mZ+XDUXgUeUdzMWVp8Qudidqs96dHp7wbqfEG +mg7nDDE6CUP16N1GN9fjteKN0LKbEF1UM55izrJ0MWAOFDmMza5gjQm7BPkaOIz 7WxeK756xHVS3X9Z4A4UYzMXy+gvOiahEztNz0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QugCTo E2oD/Akw5181hdEz10jkbZriJ+fq6eWbXxrco=; b=O57hhZ27gBq5/8Pf+kfZwf jyReChV75Usqb3IXGA4x7xP0PjN8Pam0CeyWMpwQpfx4VVh3ImlSE8SscUfxL0lJ y3lhjSqS4O8Pk1m3zOZfvACCp7teGQzQcFl6QvRGaV5TVoMO2oXJnh20dhuRG8WZ 71DlFvD5NyQm/KtqrB1FA/MRnFFEcOYxzi5aOcGy2Wot8fWYBaMcgRL01usYPPEP H7fBf+LKAZD71mnTOogNJ/1J3B4qWkBgQnRzLX46S55WOj/AnWI6S1lYhUqCl6YD g1GkfnW5JmVq5e01VQLU8nXHQJrgdcliH852k2RN4gRrW4MvGiF1qwFIBliHJrSQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdekgedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhephefhfeekgfekudevheffheeihedujeefjeevjeefudfgfeeutdeuvdeh hfevueffnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7D234A00079; Wed, 26 May 2021 21:28:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-468-gdb53729b73-fm-20210517.001-gdb53729b Mime-Version: 1.0 Message-Id: <69b31043-957c-40af-9ab9-6bcc63ccdc85@www.fastmail.com> In-Reply-To: <20210526094609.14068-3-steven_lee@aspeedtech.com> References: <20210526094609.14068-1-steven_lee@aspeedtech.com> <20210526094609.14068-3-steven_lee@aspeedtech.com> Date: Thu, 27 May 2021 10:57:43 +0930 From: "Andrew Jeffery" To: "Steven Lee" , "Linus Walleij" , "Bartosz Golaszewski" , "Rob Herring" , "Joel Stanley" , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" Cc: "Hongwei Zhang" , "Ryan Chen" , "Billy Tsai" Subject: Re: [PATCH v1 2/4] ARM: dts: aspeed-g6: Add SGPIO node. Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Steven, On Wed, 26 May 2021, at 19:16, Steven Lee wrote: > AST2600 supports 2 SGPIO master interfaces one with 128 pins another one > with 80 pins. Is there any chance the serial GPIO controllers can be explicitly listed in the Memory Space Allocation Table of the datasheet? Currently they're covered by the entry for "GPIO Controller (Parallel GPIO)" which is listed as ranging from 0x1e780000-0x1e7807ff. Admittedly the details are listed in chapter 41 for the GPIO Controller, but it would be handy to not have to dig. > > Signed-off-by: Steven Lee > --- > arch/arm/boot/dts/aspeed-g6.dtsi | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > index f96607b7b4e2..556ce9535c22 100644 > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > @@ -377,6 +377,38 @@ > #interrupt-cells = <2>; > }; > > + sgpiom0: sgpiom@1e780500 { > + #gpio-cells = <2>; > + gpio-controller; > + compatible = "aspeed,ast2600-sgpiom"; > + reg = <0x1e780500 0x100>; > + interrupts = ; > + max-ngpios = <128>; I need to think more about this one. Andrew