From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53B72199246 for ; Tue, 13 Aug 2024 12:35:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552521; cv=none; b=PjfeSa9uE6/eCiplvOmBXCi5itvZP3FJ+OmXuqTd7AIqUHscak99p1iOc8AFYUUy1wY2vwRnV+iZhRiaCaaMaZLueVgbivTIFKL/epv0oMAZkzpZI+gyXoibxFpEFNHzJ3wwBkuFvAg1zjaZ5gS4wAcnACUKOKjNzAWdcUKF6Pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552521; c=relaxed/simple; bh=wmRroHD5OUg6Qf3agbFJLQGvx/qPAQPCOGwk3gK11LQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tA7VfnDqtSLkQOFfTz9QJ+OaPh43NQQKndy+9FjOHFa1pPgM1bZXMmk0j3ASi2+ML3pRaqgxnxnvDiYeSo+k3jqdTev7PX7waakKc7xDVry2SsojL0N55RNnfXgFmtiFWbRhyJtZ+5qqH7KecYk4ljdP1H37xD9BZ+4LaQNd7w0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wMWeaEa6; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wMWeaEa6" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-368663d7f80so2899710f8f.3 for ; Tue, 13 Aug 2024 05:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723552518; x=1724157318; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4XBmrpzh2TYDockOD1rtD5XC0eW7zgp6RoYkY7KL+LA=; b=wMWeaEa69pxs+2IALh0dIEP6tWG5RxqEm6qwlAhaDNb53iulQBAuiMJyqbmC5voIpV DXdY1ngFK8cLg9qhYdb4ehwjwGCi35My3WRmzhS9ZsNNPk2vT2T9hG7zlhbXNi5W9LBu 1GK5gdyATIbgy+JhIazmEa+EIMrFJ9VUIYKf211w/s8ipauFSUkZTbjK5W1bqb0NIIQU YB3NkWTRyOafSkqfsJvnSq2mXbw69BURWy4P9AijWi85vPCxBsevq0nPhrBOwTlAl7Rz qLTbQ1mPBeKncmliyKWMvMx2Q2MYNCq9bSEES1Ql0GPNoUkbDQfEBRBcCFcQxvGVACC8 e6Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552518; x=1724157318; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4XBmrpzh2TYDockOD1rtD5XC0eW7zgp6RoYkY7KL+LA=; b=D07XAcrN03D6RXwuH+LHFpBfa2i7smJoCGkW+ZPTZb+T5kThvlKB1DIcwY8lhVbwVK qY8OyTO1aciIJ7PjbzzWuntSYKUBdkbFexmEA5tgL4v8pdOV+5WpF7e3cnGLj1DE6jay TliApOO290pcPm6VD645aOX2mvP9X+RztN2ocOnsRWFZoh9aZi3fqIlM7GJXlBK6aFtF a4aR8YaErVHbtdtKtpApkTtTlPamj7SMoo7Gevjgod7QelT6dX2KxvHPqsSEN/NF54GL NrmYj7rMgHH58zNwFurRDsjG9qk9PePGkpQ33Tuy4yRh8ZMc6dUg2XsPNNbdmB1pMUuL ADQg== X-Forwarded-Encrypted: i=1; AJvYcCWTQad8Uc+sixem3qK3srXga6+EAWg2hgj/JqqMQJpeAgA6GIDexpd6hz4ia0opdx967yhsjswKCR3ix28b0dE6JuWOWNMRcSKagg== X-Gm-Message-State: AOJu0YzDddp6kw85xAjq2+y2GcLkqewiVQTJXZ7L8uQlzbMmrChzBzid PV0n8qAjnZt58wrcw7nfeMu3JnKOFX557eYZ8RoLmojLZyya7gcfkdFaq8LrOQ8= X-Google-Smtp-Source: AGHT+IGo9esmOx/2Y4zteN5Z+67pxwJRzYVdBv5A9mVSlWCUku9O9x2DwsN2IM6SYDDbLve9RXqLiA== X-Received: by 2002:adf:9b97:0:b0:362:4ce:2171 with SMTP id ffacd0b85a97d-3716cd25d65mr2050267f8f.52.1723552517534; Tue, 13 Aug 2024 05:35:17 -0700 (PDT) Received: from [192.168.0.25] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4cfeef22sm10160372f8f.52.2024.08.13.05.35.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Aug 2024 05:35:17 -0700 (PDT) Message-ID: <69de592e-a3df-4fb3-ad0c-c8a44ae3efeb@linaro.org> Date: Tue, 13 Aug 2024 13:35:16 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 00/13] media: qcom: camss: Add sm8550 support To: Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20240812144131.369378-1-quic_depengs@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240812144131.369378-1-quic_depengs@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/08/2024 15:41, Depeng Shao wrote: > v4: > - Update dt-bindings based on comments - Krzysztof, bod, Vladimir > - Move common code into csid core and vfe core driver - bod > - Remove *_relaxed in the csid and vfe drivers - Krzysztof > - Reorganize patches in logical junks, make sure that new added > structures have users in current patch - Krzysztof > - Remove notify function and add new functions in camss for buf done > and reg update - bod > - Remove custom code to get csid base - bod > - Remove ISR function in vfe780 driver since it is never fired - bod > - Move csid_top_base to camss structure since we only have one csid > top block, and just need to get base once for csid top > - Add Vladimir's RB > - Remove prerequisite-patch-id in the cover letter since the changes > have been merged > - Add dtsi patch link for reference - Krzysztof > https://lore.kernel.org/all/20240807123333.2056518-1-quic_depengs@quicinc.com/ > - Link to v3: https://lore.kernel.org/all/20240709160656.31146-1-quic_depengs@quicinc.com/ > > v3: > - Rebased the change based on below change which will be merged firstly. > "Move camss version related defs in to resources" > Link: https://lore.kernel.org/all/20240522154659.510-1-quic_grosikop@quicinc.com/ > - Rebased the change based on Bryan's csiphy optimization change and add > these changes into this series, so that the new csiphy-3ph driver don't > need to add duplicate code. This has got Bryan's permission to add his > patches into this series. > - Refactor some changes based on the comments to move the random code to > patches where they are used. > - Remove the vfe780 irq function since it isn't doing the actual work. > - Add dt-binding for sm8550 camss driver. > Link to V2: https://lore.kernel.org/all/20240320141136.26827-1-quic_depengs@quicinc.com/ > > v2: > - Update some commit messages > Link to V1: https://lore.kernel.org/all/20240320134227.16587-1-quic_depengs@quicinc.com/ > > v1: > SM8550 is a Qualcomm flagship SoC. This series adds support to > bring up the CSIPHY, CSID, VFE/RDI interfaces in SM8550. > > SM8550 provides > > - 3 x VFE, 3 RDI per VFE > - 2 x VFE Lite, 4 RDI per VFE > - 3 x CSID > - 2 x CSID Lite > - 8 x CSI PHY > > --- @Depeng. Can you please fix the following checkpatch splats. scripts/checkpatch.pl --strict *.patch total: 0 errors, 0 warnings, 0 checks, 20 lines checked 0001-media-qcom-camss-csiphy-3ph-Fix-trivial-indentation-.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 589 lines checked 0002-media-qcom-camss-csiphy-3ph-Remove-redundant-PHY-ini.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 40 lines checked 0003-media-qcom-camss-csiphy-3ph-Rename-struct.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 49 lines checked 0004-media-qcom-camss-csiphy-Add-an-init-callback-to-CSI-.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 82 lines checked 0005-media-qcom-camss-csiphy-3ph-Move-CSIPHY-variables-to.patch has no obvious style problems and is ready for submission. CHECK: Macro argument 'offset' may be better as '(offset)' to avoid precedence issues #33: FILE: drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c:45: +#define CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(offset, n) (offset + 0x4 * (n)) CHECK: Macro argument 'offset' may be better as '(offset)' to avoid precedence issues #38: FILE: drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c:49: +#define CSIPHY_3PH_CMN_CSI_COMMON_STATUSn(offset, n) ((offset + 0xb0) + 0x4 * (n)) total: 0 errors, 0 warnings, 2 checks, 157 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0006-media-qcom-camss-csiphy-3ph-Use-an-offset-variable-t.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 517 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0007-dt-bindings-media-camss-Add-qcom-sm8550-camss-bindin.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. CHECK: Alignment should match open parenthesis #255: FILE: drivers/media/platform/qcom/camss/camss-csid.c:616: + dev_info(csid->camss->dev, "CSID:%d HW Version = %u.%u.%u\n", + csid->id, hw_gen, hw_rev, hw_step); total: 0 errors, 0 warnings, 1 checks, 289 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0008-media-qcom-camss-csid-Move-common-code-into-csid-cor.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. CHECK: braces {} should be used on all arms of this statement #677: FILE: drivers/media/platform/qcom/camss/camss-vfe.c:470: + if (output->buf[index]) { [...] + } else [...] CHECK: Unbalanced braces around else statement #682: FILE: drivers/media/platform/qcom/camss/camss-vfe.c:475: + } else CHECK: Alignment should match open parenthesis #775: FILE: drivers/media/platform/qcom/camss/camss-vfe.c:568: + if (output->state == VFE_OUTPUT_ON && + output->gen2.active_num < 2) { total: 0 errors, 0 warnings, 3 checks, 885 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0009-media-qcom-camss-vfe-Move-common-code-into-vfe-core.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 0 checks, 67 lines checked 0010-media-qcom-camss-Add-sm8550-compatible.patch has no obvious style problems and is ready for submission. 0010-media-qcom-camss-Add-sm8550-compatible.patch:6: drvier ==> driver total: 0 errors, 0 warnings, 0 checks, 253 lines checked 0011-media-qcom-camss-csiphy-3ph-Add-Gen2-v2.1.2-two-phas.patch has no obvious style problems and is ready for submission. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 CHECK: Please use a blank line after function/struct/union/enum declarations #146: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:100: +} +#define REG_UPDATE_RDI reg_update_rdi CHECK: Alignment should match open parenthesis #337: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:291: + writel(BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + i), + csid->base + CSID_BUF_DONE_IRQ_CLEAR); CHECK: Alignment should match open parenthesis #340: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:294: + writel(BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + i), + csid->base + CSID_BUF_DONE_IRQ_MASK); CHECK: Please don't use multiple blank lines #412: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.h:21: + + CHECK: Unnecessary parentheses around camss->vfe[hw_id] #643: FILE: drivers/media/platform/qcom/camss/camss.c:1854: + vfe = &(camss->vfe[hw_id]); total: 0 errors, 1 warnings, 5 checks, 607 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0012-media-qcom-camss-Add-CSID-Gen3-support-for-sm8550.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 CHECK: Alignment should match open parenthesis #219: FILE: drivers/media/platform/qcom/camss/camss-vfe.c:684: + time = wait_for_completion_timeout(&vfe->reset_complete, + msecs_to_jiffies(VFE_RESET_TIMEOUT_MS)); CHECK: Unnecessary parentheses around camss->csid[hw_id] #415: FILE: drivers/media/platform/qcom/camss/camss.c:1973: + csid = &(camss->csid[hw_id]); total: 0 errors, 1 warnings, 2 checks, 388 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0013-media-qcom-camss-Add-support-for-VFE-hardware-versio.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. --- bod