From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelvem-ot01.ext.ti.com (lelvem-ot01.ext.ti.com [198.47.23.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D913222ACD1; Fri, 2 May 2025 08:43:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.234 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746175409; cv=none; b=P3Jpyy5iTIQ+j/UxlaWL5uauGCh8yvlWJPc2w1RUuZ27YG7BYGU8+DbbK/tqYGscrN3rgkhkKOGpf51+1En0SSOzKQW4bhScMYqYy40JsbwruHtDT4dTLpLGyEhovjWvYMJto5AoFSEZQxKq1A1mCkTeZL/1jm6AefO6TOnsq8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746175409; c=relaxed/simple; bh=6X+cBIp/IpXPUbvq+II0trmKFRr8BMxaoO+Bp1G5faQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Ab3XN2QSQ4629DRV9G08xkRTbokLMpttVF8Z4TxAnwK6AG2mR21V7P78+BjS68YhcFFAEg9uY+sRDLtEB3nUMqq9HF214eL3muH1vKXPtW/i4PNvo56g7S/rxwYpcWgFny0TPw4stQBSu7AXI4ZyHNk9HyOjQob4INNgLoRJfMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=RjWJ2wWC; arc=none smtp.client-ip=198.47.23.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RjWJ2wWC" Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelvem-ot01.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 5428h9Xj3822345 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 2 May 2025 03:43:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1746175390; bh=QIbwuWHHHeqMRU/dNBr5DksK+qZ8eID81KiYJHT3Y8E=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=RjWJ2wWCOn+K4s5nwxatqxd3dIJxYNljO5i+KMwNS2RVVlqNXAJ8pOX0S2ma15qNC VK33T914yJJRBoa5nLQz/I5IJHO16WlWyYYVy/uNWD72q6VYo+aycCOucIGPry2iG3 FnnVpc2/UANQOSDb3aZNcAhJa/GsJ8gNiBP24w7M= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 5428h9rp059033 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 2 May 2025 03:43:09 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 2 May 2025 03:43:09 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 2 May 2025 03:43:09 -0500 Received: from [172.24.227.193] (devarsh-precision-tower-3620.dhcp.ti.com [172.24.227.193]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 5428h4hM108589; Fri, 2 May 2025 03:43:05 -0500 Message-ID: <69f6c225-2841-494c-b555-61cbe6b23c02@ti.com> Date: Fri, 2 May 2025 14:13:04 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Linux) Subject: Re: [PATCH v1 3/4] arm64: dts: ti: k3-am62x: Add required voltage supplies for OV5640 To: Rishikesh Donadkar , , CC: , , , , , , , , , , , , References: <20250429154133.3377962-1-r-donadkar@ti.com> <20250429154133.3377962-4-r-donadkar@ti.com> Content-Language: en-US From: Devarsh Thakkar In-Reply-To: <20250429154133.3377962-4-r-donadkar@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 29/04/25 21:11, Rishikesh Donadkar wrote: > The device tree overlay for OV5640 requires following voltage > supplies As mentioned in ov5640 data-sheet table 8-3 [1] > > AVDD-supply: Analog voltage supply, 2.8 volts > DOVDD-supply: Digital I/O voltage supply, 1.8 volts > DVDD-supply: Digital core voltage supply, 1.5 volts > [1]: Link: https://cdn.sparkfun.com/datasheets/Sensors/LightImaging/OV5640_datasheet.pdf > Add them in the overlay. > > Signed-off-by: Rishikesh Donadkar With above changes, Reviewed-by: Devarsh Thakkar Regards Devarsh > --- > .../boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso > index 7fc7c95f5cd57..fc77fc77fe0b1 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso > +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso > @@ -15,6 +15,33 @@ clk_ov5640_fixed: ov5640-xclk { > #clock-cells = <0>; > clock-frequency = <12000000>; > }; > + > + reg_2p8v: regulator-2p8v { > + compatible = "regulator-fixed"; > + regulator-name = "2P8V"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + vin-supply = <&vcc_3v3_sys>; > + regulator-always-on; > + }; > + > + reg_1p8v: regulator-1p8v { > + compatible = "regulator-fixed"; > + regulator-name = "1P8V"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc_3v3_sys>; > + regulator-always-on; > + }; > + > + reg_1p5v: regulator-1p5v { > + compatible = "regulator-fixed"; > + regulator-name = "1P5V"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + vin-supply = <&vcc_3v3_sys>; > + regulator-always-on; > + }; > }; > > &main_i2c2 { > @@ -40,6 +67,11 @@ ov5640: camera@3c { > > clocks = <&clk_ov5640_fixed>; > clock-names = "xclk"; > + > + AVDD-supply = <®_2p8v>; > + DOVDD-supply = <®_1p8v>; > + DVDD-supply = <®_1p5v>; > + > powerdown-gpios = <&exp1 13 GPIO_ACTIVE_LOW>; > > port {