From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E5F91E1E12 for ; Thu, 9 Oct 2025 19:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760037645; cv=none; b=GeQDM8qYBJuVdtfyLXKXCAL3MdrfoP0VOka3RpmFGCfzeUkwhuwvbWi0O+/eF4HKRv51vBIM+kX3U32gGovQtC3URp/wqIAmYmNner9/uPMfqXSpX1DwCFADYuucBNlUfHpDD+dH/HvW8IBFVydUYRO8M6owdZkpiZLgzBgkx+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760037645; c=relaxed/simple; bh=woqc0ajrEt9uJ5/Im+UuHQvQ2PqgtUVGDVDgEWOfPhA=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=Z1CcOXvUxkKACqOsAvQreGaAX+th+1z3xZ2hcjwj4WKmeo8vY5ca90/FHsf9cIM37XQu/OaNeuraOFjHKyq+jjC9BMyjKlRTy7IKQ5Uz25LmH+1Kow5jDmMSiu1qbGTnr/afekgqBiI75U4dkzD4PXFtKbnJRINAXnQ4fy0WQW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mg5HF1eS; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mg5HF1eS" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-781001e3846so1295239b3a.2 for ; Thu, 09 Oct 2025 12:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760037643; x=1760642443; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=70Rn4bo8hsp+8hzkUYKF6yigfv0n9RRs7N6OTgJJwNQ=; b=mg5HF1eSEGm5J/mqOMz9xBJcIZ6NWm6XetPSL1YBnaeiaC21cZaIOZbJeahD+jNu7j n7g/5tEeeYr+Q2GZrKldAtgs5+L3ccQhgULZXrwQJlGtDxS47/s/+XIwfr6ST6eD2xvy xeT18M0RNnL6M+9BupTAZyRpAQp2UQHcoJMF0TaJAQKqy9+S0KAhI6uvBytM5sxUFFhH OzF3gE7/WIQMntSzKkGZb3NNIVvdlxriWlRYaCudbVM75/MvCoHiXh1BW90t2lX5Xbm7 dq9KVUt/u9ohNy+InDXg2hCLnzHTUCxl8lzQ5ucaQ55ci1yoJ6AeHaOOATeiwtH7w2sz VorA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760037643; x=1760642443; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=70Rn4bo8hsp+8hzkUYKF6yigfv0n9RRs7N6OTgJJwNQ=; b=qgP9OUSY1JACEhidnd0VwM4/l57ashnGTyDFtAR4X4XAOnXmZDlLGRMBtUXojEYmx3 VVg69n7awdG8HKJ6FPiSifQmP8GSCR/ZsfFjl0M4ud7tOn195tOy8eCL2nBgWWN5fUg2 39ByPDrYNkqiPYbWdbDtbssah8ILhYMJndcFdhi7iX62KXd2wlBS8WOHLPGjycbuJG8x myn/h0w47cO/kVXj86WC1WWkOkpOguYtcuh6G3N/xF3nK6G6WY1N+wgbrJau+FLNqO6K /HMXVcy3UW3PGts1IJOAxgfZKELKGpKQCET0T3AcwJs0gvoJaXegYI6WxYdlaCZpgv21 z6Bg== X-Gm-Message-State: AOJu0YwxpHzj1OFUToW5AimeOzuhwCTVmYKjs2Fc7Sw2jcG19iAZheXB RgJ/yr/zLBKiUz+QZHZpPAOM+eT5YonpaJInEMjr7EFby8X9KbvaP6+y X-Gm-Gg: ASbGncvdb8tzDvlmr/WdZcJ6dE19JhowfcL50k9/4k//fSyN9upvY5CMOn9htv2MFwR j/YZANK7Tc7dIcJc+heRnIIfIYqzE9xklEoL4IG97l100EYTQ6TgZZZiGyC6NNb6QO1HQ9LDeF1 b4zUnZLV8DB2Exgq1xttMN2EMqEVAvC21nLleTdXmp5+tNLqTYxwURG1XWGxKhkb8qpmpvkJQN9 h5cgqhVG8mTogc1blD7y6rTOZ/XeiJ9UiB0bvAq6i6iKSQw2FFOgp0ACZHSCGIoAwP5L3otONA8 HQ8P3SxXMY1Px8x/XDnY9HOglIwvxz5S53Qu8hQM2HRZL2I+n+/Am4J+fmFyG+f7cugsTMRlUWz uxY+K5XQUKrhuHLKeTfZpK/plTJ7hW+mJAawuqFM+j/MOfiYOwN/e0w== X-Google-Smtp-Source: AGHT+IExINYt2VpRHQfQDcSUxK76tMIxBq4KZhCeSaRfPsxwSO1OK86eDLc1NLkNzcpsjOHWmUAbJQ== X-Received: by 2002:a05:6a00:1954:b0:784:7275:837f with SMTP id d2e1a72fcca58-79387435d78mr10324017b3a.26.1760037642658; Thu, 09 Oct 2025 12:20:42 -0700 (PDT) Received: from ehlo.thunderbird.net ([177.9.216.59]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7992b0606fesm525438b3a.12.2025.10.09.12.20.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Oct 2025 12:20:42 -0700 (PDT) Date: Thu, 09 Oct 2025 16:20:38 -0300 From: =?ISO-8859-1?Q?Eric_Gon=E7alves?= To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] arm64: dts: qcom: r0q: enable hardware clocks User-Agent: Thunderbird for Android In-Reply-To: <39d07bf1-cead-449f-85c8-4651e5296cd8@oss.qualcomm.com> References: <20250920014637.38175-1-ghatto404@gmail.com> <20250920014637.38175-5-ghatto404@gmail.com> <99D0B281-03A5-447E-A6BF-892C99829D0B@gmail.com> <39d07bf1-cead-449f-85c8-4651e5296cd8@oss.qualcomm.com> Message-ID: <6E15B597-47E7-4233-9DBB-2DAC698F4532@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On October 8, 2025 5:48:53 AM GMT-03:00, Konrad Dybcio wrote: >On 10/6/25 5:49 PM, Eric Gon=C3=A7alves wrote: >>=20 >>=20 >> On October 6, 2025 9:31:42 AM GMT-03:00, Konrad Dybcio wrote: >>> On 10/5/25 5:50 AM, Eric Gon=C3=A7alves wrote: >>>> >>>> >>>> On September 25, 2025 10:09:48 AM GMT-03:00, Konrad Dybcio wrote: >>>>> On 9/20/25 3:46 AM, Eric Gon=C3=A7alves wrote: >>>>>> Enable the real-time clocks found in R0Q board=2E >>>>>> >>>>>> Signed-off-by: Eric Gon=C3=A7alves >>>>>> --- >>>>>> arch/arm64/boot/dts/qcom/sm8450-samsung-r0q=2Edts | 15 +++++++++++= ++++ >>>>>> 1 file changed, 15 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q=2Edts b/ar= ch/arm64/boot/dts/qcom/sm8450-samsung-r0q=2Edts >>>>>> index c1b0b21c0ec5=2E=2Ec088f1acf6ea 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q=2Edts >>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q=2Edts >>>>>> @@ -225,6 +225,21 @@ vol_up_n: vol-up-n-state { >>>>>> }; >>>>>> }; >>>>>> =20 >>>>>> +&pmk8350_rtc { >>>>>> + nvmem-cells =3D <&rtc_offset>; >>>>>> + nvmem-cell-names =3D "offset"; >>>>>> + >>>>>> + status =3D "okay"; >>>>>> +}; >>>>>> + >>>>>> +&pmk8350_sdam_2 { >>>>>> + status =3D "okay"; >>>>>> + >>>>>> + rtc_offset: rtc-offset@bc { >>>>> >>>>> Is this an offset you took from somewhere downstream? >>>>> >>>>> Generally you *really don't want to* poke at random SDAM cells, >>>>> as they contain a lot of important settings (incl=2E battery/chargin= g) >>>> From another sm8450 device, I'm sure it's okay=2E >>> >>> That as an argument alone doesn't sound convincing to me, since vendor= s >>> also sometimes repurpose unused-by-Qualcomm SDAM cells >>> >>> I actually found a data source internally and this cell you're trying >>> to use is reserved for PBS (see drivers/soc/qcom/qcom-pbs=2Ec), meanin= g >>> you already fell into this trap=2E=2E >> Interesting, in this case then why does rtc still work? And >> how can I find the real cell? It's not in downstream DT=2E > >Well if nothing accesses that cell between your last write and your first >read, it will of course work, because SDAM is just a means of storage > >As for downstream/Android, it does not use SDAM at all Alright, I'll drop this patch then, thanks > >Konrad