From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= Subject: Re: [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One Date: Sat, 25 Jun 2016 00:39:52 +0200 Message-ID: <6a178035-9d0d-33ea-7afa-28a3bfb03dfe@megous.com> References: <20160623192104.18720-1-megous@megous.com> <20160623192104.18720-14-megous@megous.com> Reply-To: megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="34Cul0oThTvIVLxedS59WWI4mOXgvsSQM" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Julian Calaby Cc: Linux Sunxi , "Mailing List, Arm" , Rob Herring , Mark Rutland , Russell King , Maxime Ripard , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --34Cul0oThTvIVLxedS59WWI4mOXgvsSQM Content-Type: multipart/mixed; boundary="Ob1p0VLXQ3IuDXfEA9clEkbrGmwtoUJqF" From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= To: Julian Calaby Cc: Linux Sunxi , "Mailing List, Arm" , Rob Herring , Mark Rutland , Russell King , Maxime Ripard , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Message-ID: <6a178035-9d0d-33ea-7afa-28a3bfb03dfe-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org> Subject: Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One References: <20160623192104.18720-1-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org> <20160623192104.18720-14-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org> In-Reply-To: --Ob1p0VLXQ3IuDXfEA9clEkbrGmwtoUJqF Content-Type: text/plain; charset=UTF-8 Hi Julian, thank you for the review. You're right. I added the pinctrl client nodes. Also the patches were split incorrectly, so I fixed that too. regards, Ondrej On 24.6.2016 04:51, Julian Calaby wrote: > Hi Ondrej, > > On Fri, Jun 24, 2016 at 5:21 AM, wrote: >> From: Ondrej Jirman >> >> Xulong Orange Pi One uses GPIO based regulator that >> switches between two voltages: 1.1V and 1.3V. The >> regulator is controlled from the PL6 pin. >> >> Signed-off-by: Ondrej Jirman >> --- >> arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts >> index 0adf932..ce4ba91 100644 >> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts >> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts >> @@ -88,6 +88,25 @@ >> gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>; >> }; >> }; >> + >> + vdd_soc: gpio-regulator { >> + compatible = "regulator-gpio"; >> + >> + regulator-name = "soc-vdd-supply"; >> + regulator-min-microvolt = <1100000>; >> + regulator-max-microvolt = <1300000>; >> + regulator-boot-on; >> + regulator-type = "voltage"; >> + >> + gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; >> + states = <1100000 0x0 >> + 1300000 0x1>; >> + >> + startup-delay-us = <100000>; >> + enable-active-high; > > Don't you need to reference the new pinctl node in this one? > > Thanks, > -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. --Ob1p0VLXQ3IuDXfEA9clEkbrGmwtoUJqF-- --34Cul0oThTvIVLxedS59WWI4mOXgvsSQM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXbba4AAoJEG5kJsZ3z+/xU2cP/3/wBUv8e6NE6ZgjjzTiWiJS QXg1XFbQkB7VjtohImrNUNX+RKD1vtC21WvrpM1JbrPPO/iLChLFE0uwuy3voYkK om+aK+6U0J7RAdq74V0tS9mdGFNNpfmLULwB19V2l1k1bjCprynUNblBk4FEGUy4 WugsOFtF70kLXebGJNGgmJXhV98JNutVWFL6ivSDmsngd3a+vcLd10fhqNG0D+hb /Nn4ZgN9uT96s9oIo3Qj3r/qwXUdcyWQMPZaQpFiDqblUzP/lBSuP0xqXEYt17hF fWw+fRkm+083ZBjHnqprQUysPASH8mRy8zFlolM7rHy7CO19S0fowW4ZMYYh5/ms vOaJCRL9PO4GFV7Zsbe+e05Tkla+qCh1JXpFktLoR4FiCeODOX3Or06zll9qarAq mRv85qpD8dBa2nHvy+07HTyxyKNki7XV0SAyffmxhF/tQCae+pwLLmpaW8Nm52NC SANgHrXZUkiU8lKdLMtD+Lc4IoYmf5o43Jy0Ov1Yx0c39ZdJIaVI+C6HgCz7YaNj anHLny5oYMHY2XjXcbK9GPX5V0XqVL2OM6seGwIcSRBBQDaCm4gYLASmRkFjZ54x sKY3AMu7kmh7Lkp6+bdISsiSg3/W6HSqPh/sWCE0jV4i5E4K1I1Zet07oRFgOcTn Begc7WMR8ecFQ0+5zu0G =i0/h -----END PGP SIGNATURE----- --34Cul0oThTvIVLxedS59WWI4mOXgvsSQM--