From: Ze Huang <18771902331@163.com>
To: Conor Dooley <conor@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 0/3] Add initial support for Canaan Kendryte K230 pinctrl
Date: Tue, 8 Oct 2024 16:31:35 +0800 [thread overview]
Message-ID: <6a1a3e38-0c6b-4d79-a101-b3292a2ab3be@163.com> (raw)
In-Reply-To: <20241001-stratus-overplay-96266c33ca89@spud>
On 10/1/24 8:32 PM, Conor Dooley wrote:
> On Tue, Oct 01, 2024 at 02:27:25PM +0200, Linus Walleij wrote:
>> On Thu, Sep 26, 2024 at 5:58 PM Ze Huang <18771902331@163.com> wrote:
>>
>>> This patch series introduces support for the pinctrl driver of the Canaan
>>> K230 SoC. The K230 SoC features 64 IO pins, each of which can be configured
>>> for up to five different functions.
>>>
>>> The controller manages the entire pin configuration and multiplexing
>>> through a single register, which control features such as schmitt trigger,
>>> drive strength, bias pull-up/down, input/output enable, power source, and
>>> mux mode.
>>>
>>> The changes have been tested on CanMV-K230-V1.1 board.
>>>
>>> The pin function definition can be found here [1], and most of the DTS data
>>> was converted from the vendor's code [2].
>> Bindings ACKed and patches look good to I applied patch
>> 1 & 2 to the pin control tree.
>>
>> Please funnel patch 3 through the SoC tree.
>>
>>> prerequisite-message-id: <tencent_22BA0425B4DF1CA1713B62E4423C1BFBF809@qq.com>
>>> prerequisite-patch-id: 704efc6e76814e1877748959d7319d558c8386c1
>>> prerequisite-patch-id: c2144cf468c57b856830a61615ba6ba501e8ec58
>>> prerequisite-patch-id: ced4a01ccd8ddab2fd308d543ddf47bd1641518a
>>> prerequisite-patch-id: f8b983b301d0c14f1448b9e4c321262a509e061e
>>> prerequisite-patch-id: 834b65b6a2b037daed5cffc6a41963622568dc9c
>>> prerequisite-patch-id: 2401703b57448c9ea2c3dc7650b4502491a28944
>> I don't know about all this stuff but neither bindings or code seems
>> to contain anything that won't compile so I just assume that any of these
>> dependencies are purely for patch 3/3 and I nothing blocks me
>> merging patches 1 & 2 so I just went ahead with that.
> Yah, this should all be cos I haven't yet applied
> https://lore.kernel.org/all/tencent_22BA0425B4DF1CA1713B62E4423C1BFBF809@qq.com/
> as I am waiting for a clock driver to be sorted out.
Thank you very much for your time in reviewing and helping fix the bug!
Indeed, only patch 3 really depends on the previous patches. We are now
working on clock driver. Should we deal with patch 3 after that?
next prev parent reply other threads:[~2024-10-08 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 15:57 [PATCH v2 0/3] Add initial support for Canaan Kendryte K230 pinctrl Ze Huang
2024-09-26 15:57 ` [PATCH v2 1/3] dt-bindings: pinctrl: Add support for canaan,k230 SoC Ze Huang
2024-09-26 21:16 ` Rob Herring (Arm)
2024-09-26 15:57 ` [PATCH v2 2/3] pinctrl: canaan: Add support for k230 SoC Ze Huang
2024-09-26 15:57 ` [PATCH v2 3/3] riscv: dts: canaan: Add k230's pinctrl node Ze Huang
2024-10-01 12:27 ` [PATCH v2 0/3] Add initial support for Canaan Kendryte K230 pinctrl Linus Walleij
2024-10-01 12:32 ` Conor Dooley
2024-10-08 8:31 ` Ze Huang [this message]
2024-10-08 16:27 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a1a3e38-0c6b-4d79-a101-b3292a2ab3be@163.com \
--to=18771902331@163.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox