devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: robh+dt@kernel.org, lgirdwood@gmail.com, bgoswami@codeaurora.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	vkoul@kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v5 4/8] ASoC: wcd9335: add basic controls
Date: Wed, 23 Jan 2019 10:11:31 +0000	[thread overview]
Message-ID: <6a3664d2-9b10-d6e6-9df5-ed50364812f4@linaro.org> (raw)
In-Reply-To: <20190122185253.GG7579@sirena.org.uk>

Thanks for the review,

On 22/01/2019 18:52, Mark Brown wrote:
> On Thu, Jan 10, 2019 at 03:06:12PM +0000, Srinivas Kandagatla wrote:
> 
>> +static const char * const wcd9335_ear_pa_gain_text[] = {
>> +	"G_6_DB", "G_4P5_DB", "G_3_DB", "G_1P5_DB",
>> +	"G_0_DB", "G_M2P5_DB", "UNDEFINED", "G_M12_DB"
>> +};
> 
> Gains should be controlled with Volume controls, not enums.  Provide
> information on the levels via TLV.
I agree, I will fix this as well in next version!
> 
>> +static const char * const rx_hph_mode_mux_text[] = {
>> +	"CLS_H_INVALID", "CLS_H_HIFI", "CLS_H_LP", "CLS_AB", "CLS_H_LOHIFI"
>> +};
> 
> Is there a strong reason not to use more human readable strings here?
> 
No, I can rename them to below if it helps reader.

"Class-H Hi-Fi", "Class-H Low Power",   "Class-AB", "Class-H Hi-Fi Low 
Power".

Thanks,
srini

  reply	other threads:[~2019-01-23 10:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 15:06 [PATCH v5 0/8] ASoC: Add support to WCD9335 Audio Codec Srinivas Kandagatla
2019-01-10 15:06 ` [PATCH v5 1/8] ASoC: dt-bindings: update wcd9335 bindings Srinivas Kandagatla
2019-01-10 15:06 ` [PATCH v5 2/8] ASoC: wcd9335: add support to wcd9335 codec Srinivas Kandagatla
2019-01-22 18:41   ` Mark Brown
2019-01-23 10:11     ` Srinivas Kandagatla
2019-01-10 15:06 ` [PATCH v5 3/8] ASoC: wcd9335: add CLASS-H Controller support Srinivas Kandagatla
2019-01-10 15:06 ` [PATCH v5 4/8] ASoC: wcd9335: add basic controls Srinivas Kandagatla
2019-01-22 18:52   ` Mark Brown
2019-01-23 10:11     ` Srinivas Kandagatla [this message]
2019-01-10 15:06 ` [PATCH v5 5/8] ASoC: wcd9335: add playback dapm widgets Srinivas Kandagatla
2019-01-10 15:06 ` [PATCH v5 6/8] ASoC: wcd9335: add capture " Srinivas Kandagatla
2019-01-10 15:06 ` [PATCH v5 7/8] ASoC: wcd9335: add audio routings Srinivas Kandagatla
2019-01-10 15:06 ` [PATCH v5 8/8] ASoC: apq8096: add slim support Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a3664d2-9b10-d6e6-9df5-ed50364812f4@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).