From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Naveen Kumar Goud Arepalli <quic_narepall@quicinc.com>,
quic_nitirawa@quicinc.com, agross@kernel.org,
andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] arm64: dts: qcom: sa8775p-ride: Update L4C parameters
Date: Tue, 11 Jul 2023 13:40:42 +0200 [thread overview]
Message-ID: <6a398153-8ff4-3cb7-868c-44fd04a7ef90@linaro.org> (raw)
In-Reply-To: <20230711105915.30581-1-quic_narepall@quicinc.com>
On 11.07.2023 12:59, Naveen Kumar Goud Arepalli wrote:
> L4c is the supply for UFS vccq, As per UFS spec range of vccq is
> 1.14V to 1.26V, There are stability issues when operating at
> marginal voltage. Hence configure the min and max vccq voltages
> to 1.2V.
>
> Signed-off-by: Naveen Kumar Goud Arepalli <quic_narepall@quicinc.com>
> ---
Couple of things I'd like you to fix in the future:
1. you sent a v2 minutes after v1, with no changelog or reference
(ideally you should include something like:
Changes since v1:
- foo
- bar
- baz
Link to v1: ...)
You can use the b4 tool [1] which makes this really easy for everyone!
2. You overtook the series from your colleague. It's okay, but:
- you should have mentioned this (see point 1)
- it's fine for your colleagues to send your patches, so long as all
of the co-authors AND the person sending add their Signed-off-by tags
Also, check out [2].
Aside from that, this patch looks sane to me.
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
[1] https://b4.docs.kernel.org/en/latest/index.html
[2] https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Konrad
> arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> index ab767cfa51ff..26f5a4e0ffed 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> @@ -153,8 +153,8 @@
>
> vreg_l4c: ldo4 {
> regulator-name = "vreg_l4c";
> - regulator-min-microvolt = <1100000>;
> - regulator-max-microvolt = <1300000>;
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> /*
> * FIXME: This should have regulator-allow-set-load but
next prev parent reply other threads:[~2023-07-11 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 10:59 [PATCH V2] arm64: dts: qcom: sa8775p-ride: Update L4C parameters Naveen Kumar Goud Arepalli
2023-07-11 11:40 ` Konrad Dybcio [this message]
2023-07-14 5:34 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a398153-8ff4-3cb7-868c-44fd04a7ef90@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_narepall@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).