From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F30EB64DC for ; Tue, 11 Jul 2023 11:40:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbjGKLks (ORCPT ); Tue, 11 Jul 2023 07:40:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbjGKLkr (ORCPT ); Tue, 11 Jul 2023 07:40:47 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B34B512F for ; Tue, 11 Jul 2023 04:40:46 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b698937f85so91087461fa.2 for ; Tue, 11 Jul 2023 04:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689075645; x=1691667645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FOb4V8162vKUOvo7wKDsANAZxGIZvl55fC9syM8H/ag=; b=ij3igYc4u8/1LaFt+NKVgVhxQkkTIHZZqTP3rQ3Crpr+zZIepL4Z+dAe1XExh8KT3c o4EsGOKVnfEi6yzCo84S/4a2w3S/1fBs1fJH27rASDePKeeB6QrtlaNvDbWbjSlz+Az+ AURVSe/NcvqfiHs8Z++Xg4de8AOLcZ6rhhDEIwg5R4cGOEVTp7CFET84qhZuBz3/e3ac Fs/PigXIbQgk5jGNFvuJ2RqHw3VbyjHj7sb+0egzE/wjvYRLuOl3WFBrctSXKhH2+F+f TIE3bbO1v4Q3vjaV5n6yq+HRYqljEPy9d+i8e4LTxFOtS5iDrREt3LBh5zXzf1sVxFXr veeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689075645; x=1691667645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FOb4V8162vKUOvo7wKDsANAZxGIZvl55fC9syM8H/ag=; b=V6tFDGPb8UQOkorFRDAiI8m6xPQYA+IkqTD2G2aFMHLwAckfe3hW+kXTO86kBeBnjf 6uZZSPFp+3Y1jLhTkSpDmZNNthaaEI0DI5lJkcdjaCw4qFw5/SaxUZTDIHYJVJJ/YAv6 wBby9iO/06azvTW1nz76jZZdBrH7bA3VJNovRBX7c14CJneon69wZwhr8DB3UUI7RAdH w9PTZjNx3sJDy/6KtSIE55kQueGUA8sKp2FhoRnlO7Vj8DoPUkXR8hM1+lT7KHGbxFtE YlPDhO0+uQaPZYMguy0QB+FoiDB+B8pHntqDduCFl9rFrY1IUgbfWsDfL8Ljx3rnlvau KDfw== X-Gm-Message-State: ABy/qLbXhFGmyGNvkzhECmCovx8Gcm0/dEOc+7YQ1+HGvCp7HRiZNvES VSGdZdL9XmJfdTGqLyJXob32cA== X-Google-Smtp-Source: APBJJlHFKdkSAuljFfDBnBKOJY5dlqtGUlVam2d2ELh6oh3HkBBJLd8AOi5Fe8dARpQuArAcxgwZxg== X-Received: by 2002:a2e:948a:0:b0:2b7:842:a64c with SMTP id c10-20020a2e948a000000b002b70842a64cmr11281027ljh.5.1689075644994; Tue, 11 Jul 2023 04:40:44 -0700 (PDT) Received: from [192.168.1.101] (abyl96.neoplus.adsl.tpnet.pl. [83.9.31.96]) by smtp.gmail.com with ESMTPSA id j23-20020a2e8017000000b002b6daf32c7csm416587ljg.97.2023.07.11.04.40.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 04:40:44 -0700 (PDT) Message-ID: <6a398153-8ff4-3cb7-868c-44fd04a7ef90@linaro.org> Date: Tue, 11 Jul 2023 13:40:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V2] arm64: dts: qcom: sa8775p-ride: Update L4C parameters Content-Language: en-US To: Naveen Kumar Goud Arepalli , quic_nitirawa@quicinc.com, agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230711105915.30581-1-quic_narepall@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230711105915.30581-1-quic_narepall@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11.07.2023 12:59, Naveen Kumar Goud Arepalli wrote: > L4c is the supply for UFS vccq, As per UFS spec range of vccq is > 1.14V to 1.26V, There are stability issues when operating at > marginal voltage. Hence configure the min and max vccq voltages > to 1.2V. > > Signed-off-by: Naveen Kumar Goud Arepalli > --- Couple of things I'd like you to fix in the future: 1. you sent a v2 minutes after v1, with no changelog or reference (ideally you should include something like: Changes since v1: - foo - bar - baz Link to v1: ...) You can use the b4 tool [1] which makes this really easy for everyone! 2. You overtook the series from your colleague. It's okay, but: - you should have mentioned this (see point 1) - it's fine for your colleagues to send your patches, so long as all of the co-authors AND the person sending add their Signed-off-by tags Also, check out [2]. Aside from that, this patch looks sane to me. Acked-by: Konrad Dybcio [1] https://b4.docs.kernel.org/en/latest/index.html [2] https://www.kernel.org/doc/html/latest/process/submitting-patches.html Konrad > arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > index ab767cfa51ff..26f5a4e0ffed 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > @@ -153,8 +153,8 @@ > > vreg_l4c: ldo4 { > regulator-name = "vreg_l4c"; > - regulator-min-microvolt = <1100000>; > - regulator-max-microvolt = <1300000>; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > regulator-initial-mode = ; > /* > * FIXME: This should have regulator-allow-set-load but