From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DC604854E9 for ; Thu, 1 Oct 2026 06:20:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790835653; cv=none; b=FoBPGfpdLO4TU69N9/8/9VFhwB10U4tjHf0/aytu0PiVN2qmfkwrNpyY3ay1i6Z/5ArkPlvgROeRw9QEwJWIgdZmHHzt6QmDbaGbCnEH8MnLK6RvCqQdx83zQUPYc3atF0Pu5WZ4v1HKOGq5PGDJIOQw24iVlmSM7fkh9XINYwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790835653; c=relaxed/simple; bh=iOwAsP8ps7n4B96WTbEdmqoobOdeSutrQrYZKlneRYs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TxiB8/OziKWiXkLOoSqrA/aJ/F8VGAUaJ1xF0BsqksQMrrQEZBzhIbQrVSVd6yfJRbAst/0HFTajmFUL4ceScPgW5xaZLa20hAUFCAgVE9XpnEwfUZxzgd/jqkoRXpQrVOoReuWTAOcXv5ipXl9SabQRnHC2gVVI7XmZrRKfaSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=faG7x515; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZPK0ZpeQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="faG7x515"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZPK0ZpeQ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6913g2n61510672 for ; Thu, 1 Oct 2026 06:20:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EoL5Zq8dAWHB7YFnbRFE1n4oiWuxqDXZ03Ci1CauKnk=; b=faG7x515dHo3R6Vf 8KitqwxL1PJ9HvA9/n4629QyhefQO0UlKuDEtvUXdBioZb1/87i+4bh+bItZaQYN F6P29hOpet4pZsgngVMcBEuplJPsGuXPc0phC1sH+2LQjE70Rw6PaAUsfVxNara7 pD2remKAdRikY87HhWOBH7e+0NW161DMYKLLKIH6iKGAD9So3on2M4Y5ZjVB4ZXc /gRaLOlC7LJ17fWrmTlXzPLP1tFoz/9A4vbIXJTfep/A3uVgJE1naXP/1nivIFjs JLrnlf+heLrTTGUHflLEjPFAwMVlwCviXIotkwSh/1DjJ07HXGCMqKWlx7wEolig gLHa8A== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h1bh59cft-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 01 Oct 2026 06:20:51 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38e8fee6af3so6068355a91.1 for ; Wed, 30 Sep 2026 23:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790835651; x=1791440451; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EoL5Zq8dAWHB7YFnbRFE1n4oiWuxqDXZ03Ci1CauKnk=; b=ZPK0ZpeQXlkiuD55fDsJ59Kc4MZ5JrJiNZAeoDxrzjsEZub+gHxWLF+RZCGT/uMTii ZLPbqz7jMj6FZEpf788dQ3ONPseaeLoqk6M22HYKeIc2ve/2BWB6ZVO2AUkTuogUWOC5 I/Ffx+VTND1C6fC+fjki+DglVMUpxKLjyklWlkIJPikMiTcQCRVCcHkFISoJ9sezUeY0 7MFOf3OkrtnqrqWtRPLb7cw3xyj2poBmG0DVYUfmzkOTFcx03PXBscB054xPpHDdRGsC Uw26KFnM44iVwmOxBhx3Ov4Bo/ai35ipQ4qUq//Pjt/gY+tLomWHbGaZ/cYm8tPDgxxj X4sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790835651; x=1791440451; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EoL5Zq8dAWHB7YFnbRFE1n4oiWuxqDXZ03Ci1CauKnk=; b=MqlwF1i9InXZmV1cLfAY1lAfpPdL63A+9w/Zk1cR8WJVgWmS1j6+xwLFQHcIRlmZ1W Clli3jJbcZ8reAv7B5Gjl1G9kAhIwOXrlcvDsq6R8z123KAXOvtdJFlXJjxbbNbaJ4yn iLHuuZ+wWb87QKSvH6oA9mlvykIT8bIGPF8Fqy7I8mWF30psJUM/GI4lJIVf5znXXwyA tUrs0kMzicff6aeTjXHrTNuiLkwILVEiEyOaKrO2zUWciCV3uhI6R0T8Y18TCar68KWj vwob83ychsfDrz3n1TiqmYRd2m/U5XkoaHqGT+geF8taImqdo0YOGRkGnAu6Un9mW6BV b2dg== X-Forwarded-Encrypted: i=1; AKwUvBydQLMH62FA7l592w5oxm9sea8n7nsDJLt7JdqYVLi2SKVl0+371vtIcVa5fn/sQK1Q4fzwNCkjVo8E@vger.kernel.org X-Gm-Message-State: AFq9FYKjy/97DJsIjFvKLCBN8b2d73SJBThjZvDWebeTZt/ugfceY4Eq Ggn8SBQc7mq85eCYKEPYl5YY1YW3HEydhjwwZvUIrlMlxPQctjy+nieH8j+TRVfwv086m30Faln dP28EQoORcgRGI/GQtEF6ABC/Mm+mqayZ+GjKSJe+KMrzwco+lNb4B/XWygrzMxhy X-Gm-Gg: AYBFou1Iv24MBYVSwmoT8KausMVv2fBEseBbMBpRhAVuRSDhoxbbrJ0oIosIRQ2L0IC d6GJypu0dwAomi6SbEH0HyC38c3BPZBv/KnFVryTknaA6l3YRqTkpK1FXV5lrHaUMvf0yR3sn6O LBDmks2fNpd2XbUpuO46wBPNFfEMeCagIWQy+lGCG2Vc9lI/ftncY/0+T31Zpu45VcXRxvmWWcx a4YJD9AgLCUGKJIOufC1yF85oK2eV0Z/CBRo7d4qEeFRaf1wJtsWEnBUlizSJ45uUcoZluFe328 FIWCB4pG28YKsi4tvAYAEI1ZUuJUGk2pECmwASiu8wdLyIMJJ9DZKDr4rns9ygqr4WWC5UJGJuQ UPVvTP3rkNz2TE4mxgnIQrnfzGko= X-Received: by 2002:a17:90b:4b0e:b0:3a0:d75c:239f with SMTP id 98e67ed59e1d1-3a4d1505448mr3202075a91.11.1790835650469; Wed, 30 Sep 2026 23:20:50 -0700 (PDT) X-Received: by 2002:a17:90b:4b0e:b0:3a0:d75c:239f with SMTP id 98e67ed59e1d1-3a4d1505448mr3202053a91.11.1790835649973; Wed, 30 Sep 2026 23:20:49 -0700 (PDT) Received: from [10.218.30.203] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a4f479dc9fsm2788610a91.15.2026.09.30.23.20.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Sep 2026 23:20:49 -0700 (PDT) Message-ID: <6a685e0b-c198-49ff-8941-5017fdbd48c2@oss.qualcomm.com> Date: Thu, 1 Oct 2026 11:50:46 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings To: sashiko-reviews@lists.linux.dev Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org References: <20260930-shikra-el2-v2-0-f0822be5aaee@oss.qualcomm.com> <20260930-shikra-el2-v2-2-f0822be5aaee@oss.qualcomm.com> <20260930115553.C3CA71F000FF@smtp.kernel.org> Content-Language: en-US From: Komal Bajaj In-Reply-To: <20260930115553.C3CA71F000FF@smtp.kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: XxQZlem5xOgigkx_eSUZuqT9Y4HrYuFM X-Proofpoint-Spam-Info: AW1haW4tMjYxMDAxMDAyNSBTYWx0ZWRfX9+8wjz1nvqnx +INxuY9UP80jDfv/G96jC7V3ZalrS5Sgn15iabsVIi4NUc2+E10ARLQakoJC9TvJ0rtuF2tD8gX nK7Mj8WDklUECpeAReYJOKuUDeQ9iIs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDAxMDAyNSBTYWx0ZWRfXyauSxlj8nPl/ EnaEQl1pi1U4GHkSimFhWMoSEfqk/5tdXGGr2ys6U9NYql85VvKGVFUyl7Y7rDjtbJqQcWxUNN7 qFWyEw52dyaIz3EACCrs5/j5UiBNDg/TVa+QcH2yfmmDUAH5hxU9bHjbvEUSgi31QCNq3SACo+A myCYyFVTTo3fZCqmPs6olOSwzY2EwRSD9vW1fUA059UPzqHjSBfMNh6TLZCMfnk44iZlEm3SH67 QNYOw5CqNsN9vYxFVQLz7fpmxg7D2mdEi727Cc7KiQ4QdcrIR0bmND72mhEJxVrOyR74W/SjvCs yvSXdI132oF3ne5GYnpdVsZ05dwbJPitxhsk9WMXb0kGeo6GfdVoHkVIJEIzDxLE67n4KGZraXe iQ11PWWcy1Ri8AlHKASpW02PV0ZSgI3kHwv77tsVBuUcRKFcaTA1AQbqttTZfz6zd03bChGONu0 bOtyOlONUcaRxzyhLZw== X-Authority-Analysis: v=2.4 cv=NuxE4MdJ c=1 sm=1 tr=0 ts=6abdfbc3 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=xrLqKWkFl_EJ2zcK8ggA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: XxQZlem5xOgigkx_eSUZuqT9Y4HrYuFM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-01_02,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2610010025 On 9/30/2026 5:25 PM, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > - [Medium] Missing EL2 targets for camera EVK variants > - [Medium] Undocumented disablement of GPU zap shader in EL2 overlay > -- > > commit 07c9abdfac5fabfba8cfb72f094624db1d5cb41b > Author: Komal Bajaj > > arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings > > This commit introduces an EL2-specific DeviceTree overlay for Shikra boards. > It explicitly configures the firmware IOMMU streams for remote processors, > allowing Linux to boot directly at EL2 without a hypervisor. > >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 4e714251d5e6b..634914b8f229b 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile > [ ... ] >> @@ -377,6 +388,7 @@ shikra-iqs-evk-imx577-camera-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-imx577-ca >> dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk-imx577-camera.dtb >> dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk-imx577-camera.dtb >> dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-imx577-camera.dtb > [Severity: Medium] > The commit message states the overlay is applied to "all Shikra EVK variants > devices", but are we missing the EL2 targets for these camera variants? > > Without adding targets like shikra-cqm-evk-imx577-camera-el2-dtbs, the camera > variants cannot be built or booted natively at EL2. Camera variants have not yet been validated in EL2, so the corresponding *-el2-dtbs targets were not added. We will add them in a follow-up change once EL2 validation is completed. >> + >> dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb > [ ... ] > >> diff --git a/arch/arm64/boot/dts/qcom/shikra-el2.dtso b/arch/arm64/boot/dts/qcom/shikra-el2.dtso >> new file mode 100644 >> index 0000000000000..d2f3186bd47db >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/shikra-el2.dtso >> @@ -0,0 +1,23 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + * >> + * Shikra specific modifications required to boot in EL2. >> + */ >> + >> +/dts-v1/; >> +/plugin/; >> + >> +&gpu_zap_shader { >> + status = "disabled"; >> +}; > [Severity: Medium] > Is it intended to disable the GPU zap shader in this overlay without > mentioning it in the commit message? > > The commit message only describes adding remoteproc SMMU mappings. While > disabling the zap shader might be necessary for EL2 boot, this hardware > feature disablement is currently an undocumented side effect. Zap shader is not required in EL2, as Linux can perform GPU zap sequence on its own. Disabling it is intentional. Thanks Komal