devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kamel BOUHARA <kamel.bouhara@bootlin.com>
To: Jeff LaBundy <jeff@labundy.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Marco Felsch <m.felsch@pengutronix.de>,
	catalin.popescu@leica-geosystems.com,
	mark.satterthwaite@touchnetix.com,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Gregory Clement <gregory.clement@bootlin.com>,
	bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH v16 3/3] Input: Add TouchNetix axiom i2c touchscreen driver
Date: Fri, 12 Jul 2024 11:11:44 +0200	[thread overview]
Message-ID: <6a7bfad6adee31a10b93f465d35ee8ae@bootlin.com> (raw)
In-Reply-To: <a38609ed1d2a181287f4758e3272c553@bootlin.com>

[...]

>>> +/*
>>> + * axiom devices are typically configured to report touches at a 
>>> rate
>>> + * of 100Hz (10ms) for systems that require polling for reports.
>>> + * When reports are polled, it will be expected to occasionally
>>> + * observe the overflow bit being set in the reports.
>>> + * This indicates that reports are not being read fast enough.
>> 
>> This comment is strange; if reports are not read quickly enough at
>> the default rate, why not set the default rate at the slowest for
>> which the overflow bit is not set?
>> 
> 
> The rate has been set to the give a good user experience regardless of
> this overflow bit that isn't even processed here.
> 

and therefore I might remove the part refering to this overflow bit in 
the comment.

Regards,
Kamel

      reply	other threads:[~2024-07-12  9:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 14:25 [PATCH v16 0/3] Input: Add TouchNetix axiom touchscreen driver Kamel Bouhara
2024-07-03 14:25 ` [PATCH v16 1/3] dt-bindings: vendor-prefixes: Add TouchNetix AS Kamel Bouhara
2024-07-03 14:25 ` [PATCH v16 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen Kamel Bouhara
2024-07-03 14:25 ` [PATCH v16 3/3] Input: Add TouchNetix axiom i2c touchscreen driver Kamel Bouhara
2024-07-03 18:22   ` Marco Felsch
2024-07-12  8:53     ` Kamel BOUHARA
2024-07-07 19:20   ` Jeff LaBundy
2024-07-12  9:07     ` Kamel BOUHARA
2024-07-12  9:11       ` Kamel BOUHARA [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a7bfad6adee31a10b93f465d35ee8ae@bootlin.com \
    --to=kamel.bouhara@bootlin.com \
    --cc=bsp-development.geo@leica-geosystems.com \
    --cc=catalin.popescu@leica-geosystems.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregory.clement@bootlin.com \
    --cc=jeff@labundy.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=mark.satterthwaite@touchnetix.com \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).