From: Sharat Masetty <smasetty@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
dianders@chromium.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
mka@chromium.org, dri-devel@freedesktop.org
Subject: Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks
Date: Wed, 26 Feb 2020 16:47:07 +0530 [thread overview]
Message-ID: <6a7c1f39-a85f-4a99-fed3-71001bdb6128@codeaurora.org> (raw)
In-Reply-To: <20200220203509.GA14697@bogus>
On 2/21/2020 2:05 AM, Rob Herring wrote:
> On Thu, 20 Feb 2020 13:42:22 +0530, Sharat Masetty wrote:
>> This patch adds a clock definition needed for powering on the GPU TBUs
>> and the GPU TCU.
>>
>> Signed-off-by: Sharat Masetty <smasetty@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clock-names: ['bus', 'iface'] is too short
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clocks: [[4294967295, 123], [4294967295, 124]] is too short
>
> See https://patchwork.ozlabs.org/patch/1241297
> Please check and re-submit.
Hi Rob, These issues seem to be from the original code and not related
to my patch. Are these going to be blocking errors?
next prev parent reply other threads:[~2020-02-26 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 8:12 [PATCH] Update arm,smmu.yaml bindings doc Sharat Masetty
2020-02-20 8:12 ` [PATCH] dt-bindings: arm-smmu: update the list of clocks Sharat Masetty
2020-02-20 20:35 ` Rob Herring
2020-02-26 11:17 ` Sharat Masetty [this message]
2020-02-26 14:33 ` Rob Herring
2020-03-02 6:35 ` Sharat Masetty
2020-02-20 21:02 ` Matthias Kaehlcke
2020-02-26 13:55 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a7c1f39-a85f-4a99-fed3-71001bdb6128@codeaurora.org \
--to=smasetty@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).