From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Robert Marko <robimarko@gmail.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: net: ipq4019-mdio: document IPQ6018 compatible
Date: Mon, 14 Nov 2022 09:26:53 +0100 [thread overview]
Message-ID: <6a9a6d2a-9fa4-a09f-9a2a-35e756ac63e9@linaro.org> (raw)
In-Reply-To: <20221113184727.44923-1-robimarko@gmail.com>
On 13/11/2022 19:47, Robert Marko wrote:
> Document IPQ6018 compatible that is already being used in the DTS along
> with the fallback IPQ4019 compatible as driver itself only gets probed
> on IPQ4019 and IPQ5018 compatibles.
>
> This is also required in order to specify which platform require clock to
> be defined and validate it in schema.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> .../devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
> index ad8b2b41c140..2463c0bad203 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
> @@ -14,9 +14,16 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - qcom,ipq4019-mdio
> - - qcom,ipq5018-mdio
> + oneOf:
> + - items:
These are just one item, so drop "items".
> + - enum:
> + - qcom,ipq4019-mdio
> + - qcom,ipq5018-mdio
> +
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-14 8:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 18:47 [PATCH 1/5] dt-bindings: net: ipq4019-mdio: document IPQ6018 compatible Robert Marko
2022-11-13 18:47 ` [PATCH 2/5] dt-bindings: net: ipq4019-mdio: add IPQ8074 compatible Robert Marko
2022-11-14 8:27 ` Krzysztof Kozlowski
2022-11-13 18:47 ` [PATCH 3/5] dt-bindings: net: ipq4019-mdio: require and validate clocks Robert Marko
2022-11-14 8:29 ` Krzysztof Kozlowski
2022-11-13 18:47 ` [PATCH 4/5] dt-bindings: net: ipq4019-mdio: document required clock-names Robert Marko
2022-11-14 8:30 ` Krzysztof Kozlowski
2022-11-13 18:47 ` [PATCH 5/5] arm64: dts: qcom: ipq8074: add SoC specific compatible to MDIO Robert Marko
2022-11-14 8:30 ` Krzysztof Kozlowski
2022-11-14 8:26 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a9a6d2a-9fa4-a09f-9a2a-35e756ac63e9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).