From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fabio Estevam <festevam@gmail.com>, daniel.lezcano@linaro.org
Cc: rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com,
linux-pm@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH v3 1/3] dt-bindings: thermal-zones: Document critical-action
Date: Tue, 29 Aug 2023 08:41:58 +0200 [thread overview]
Message-ID: <6aa6f1b0-0ccc-c2a7-8be1-ffd444193400@linaro.org> (raw)
In-Reply-To: <20230828195902.1645169-1-festevam@gmail.com>
On 28/08/2023 21:59, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Document the critical-action property to describe the thermal action
> the OS should perform after the critical temperature is reached.
We see that from the diff. You should explain here why you need it, why
this is good idea. You should provide here answers to my concerns on v1,
so you do not get exactly the same question from Conor or Rob or anyone
else.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2023-08-29 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 19:59 [PATCH v3 1/3] dt-bindings: thermal-zones: Document critical-action Fabio Estevam
2023-08-28 19:59 ` [PATCH v3 2/3] reboot: Introduce hw_protection_reboot() Fabio Estevam
2023-08-28 19:59 ` [PATCH v3 3/3] thermal: thermal_core: Allow rebooting after critical temp Fabio Estevam
2023-08-29 6:41 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aa6f1b0-0ccc-c2a7-8be1-ffd444193400@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amitk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).