From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh2-smtp.messagingengine.com (fhigh2-smtp.messagingengine.com [103.168.172.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37D391A4E6B for ; Tue, 3 Sep 2024 01:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725328384; cv=none; b=CxDcs9fVsObwZS0lWxDovT0xHsTU855MOrFogkHAdouDOc+wLe5qP2UdU7YgtuX9JMZfJehlbPeVjPhDAlqpQuWc1za2kwwy4HdH7GwVYf55ypDU+BASs871koDgIq9k8nIN4y+lLrOsezOvUl7Zmd9kZFSt9MvB2VkIfX7ESLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725328384; c=relaxed/simple; bh=7ulVwEyOK49fvq6nYlabowd606MGll6rr8Z4xKikYPQ=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=uzB18tbcpqnOF0k79ZZFl0zDKGGAdqvd4yw0MNk3anECtC3IShG7BQ25fam2/Ozi6K3FnGYt64WtqHDwn5S789RgnFItv6YpwkWk3z26lY3eyVK8/oQ4v1i25EMKDlGne1ZKpoIK9eea/bu2TIush3Kexc8w0TP7v5ygTH82zVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=testtoast.com; spf=pass smtp.mailfrom=testtoast.com; dkim=pass (2048-bit key) header.d=testtoast.com header.i=@testtoast.com header.b=Z9mXTYKS; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=tBNgqY6m; arc=none smtp.client-ip=103.168.172.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=testtoast.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=testtoast.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=testtoast.com header.i=@testtoast.com header.b="Z9mXTYKS"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tBNgqY6m" Received: from phl-compute-02.internal (phl-compute-02.nyi.internal [10.202.2.42]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 492831140187; Mon, 2 Sep 2024 21:53:01 -0400 (EDT) Received: from phl-imap-07 ([10.202.2.97]) by phl-compute-02.internal (MEProxy); Mon, 02 Sep 2024 21:53:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=testtoast.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1725328381; x=1725414781; bh=eDbi4gWSWJjjOV7pKTumnIfA9DfLYr7+ Xf9PEudOE90=; b=Z9mXTYKSJMM0Ru0OoAhiZ+v8EKlo81YHrN6sFEgwhQZtt3Si ISW6nOaeF/YtLojwW69YmQL9+VdzqzjthYPvnEbdeYTN//XqvLMVtNsazWH+Gtrf EFRSjLWgHXe42alK8rbSsqbiM1fTYnYOetfI/5p0EXS8zkTYYToHkDZnbpIt1XYT 5i1MW69C1otTVI0M+SFQeC7JCYfGLxtgsqNq1Wdcw7BQiVcgHYmJrIHdf3OiuPvb PGCoojYyzS37C2nFPJb0OVMaCpNJcIPWxwX+UweXc3ASqrNQs2Dy/sN8W/dAwS/P nWh+PgVp1CCPNP3n9VfgDAmP5ynBtfTYyhS/3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725328381; x= 1725414781; bh=eDbi4gWSWJjjOV7pKTumnIfA9DfLYr7+Xf9PEudOE90=; b=t BNgqY6mamGsbVwkySJH0MRBfm6ValSEAwSn3rP7+R2IC2aafzRhAovQXomCtOl4m kFPtzSMvIuAu16zbTEZB+N1J2O22XoJFbOav0ii+HSS9tW01z4jMPKNRNwJsPfaZ yKCSJ2WM+AedgZCyxYIc+Yd1rpZTzQIVhFmzreLxZEH9JDj0MVMxxdT3V92aavF0 QqhTMgRvOtCbxG0HchdQu6qc8R66xK/HQtrEr45892J6TSWl72lx509M0PqwPi8Y Sl6idqNcMnp/PZpGTJ46Tohb7IE/L7krZLy/WdRZf8zjAvVfZTThrot9oLDlBWKp kBjv2YjS079zpyjnuFqSw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehgedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftfihrghnucghrghlkhhlihhnfdcuoehrhigrnhesthgvshhtthhorg hsthdrtghomheqnecuggftrfgrthhtvghrnhepjefhueekjeejgfduvdffheevveejhfdt uddthfduuddvveefjeffgfdvleefuefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomheprhihrghnsehtvghsthhtohgrshhtrdgtohhmpdhnsggp rhgtphhtthhopeduiedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggrnhhivg hlsehffhiflhhlrdgthhdprhgtphhtthhopegrihhrlhhivggusehgmhgrihhlrdgtohhm pdhrtghpthhtohepkhhikhhutghhrghnleeksehgmhgrihhlrdgtohhmpdhrtghpthhtoh epmhgrtghrohgrlhhphhgrkedvsehgmhgrihhlrdgtohhmpdhrtghpthhtoheptghonhho rhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegtohhnohhrsehkvghrnhgvlh drohhrghdprhgtphhtthhopehkrhiikhdoughtsehkvghrnhgvlhdrohhrghdprhgtphht thhopehmrhhiphgrrhgusehkvghrnhgvlhdrohhrghdprhgtphhtthhopehrohgshheskh gvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: idc0145fc:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 62404BA006E; Mon, 2 Sep 2024 21:53:00 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 03 Sep 2024 13:52:00 +1200 From: "Ryan Walklin" To: "Neil Armstrong" , "Maxime Ripard" Cc: "Conor Dooley" , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, "Jessica Zhang" , "Sam Ravnborg" , "David Airlie" , "Daniel Vetter" , "Maarten Lankhorst" , "Thomas Zimmermann" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Hironori KIKUCHI" , "Chris Morgan" Message-Id: <6ab54fb5-8723-457d-b5e6-483f82faf30e@app.fastmail.com> In-Reply-To: References: <20240828-aboriginal-vivid-goldfish-3ee4fc@houat> <8490347B-2729-4B79-869B-FFCE41E0A7F9@testtoast.com> Subject: Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, 30 Aug 2024, at 7:56 PM, Neil Armstrong wrote: Thanks Neil, > > The only valid compatible with anbernic would be to use the exact > device in use and not a wildcard, > so you said the 3 devices using this panel are: > anbernic,rg35xx-2024 > anbernic,rg35xx-plus > anbernic,rg35xx-h > you should introduce 3 compatibles: > anbernic,rg35xx-2024-panel > anbernic,rg35xx-plus-panel > anbernic,rg35xx-h-panel > > but it's duplicating for nothing, to you should use fallbacks for 2 of > them to have in DT : > > anbernic,rg35xx-2024-panel > anbernic,rg35xx-plus-panel, anbernic,rg35xx-2024-panel > anbernic,rg35xx-h-panel, anbernic,rg35xx-2024-panel > > and only use anbernic,rg35xx-2024-panel in the driver. > > In this case bindings should be like: > properties: > compatible: > oneOf: > - const: anbernic,rg35xx-2024-panel > - items: > - enum: > - anbernic,rg35xx-plus-panel > - anbernic,rg35xx-h-panel > - const: anbernic,rg35xx-2024-panel > > (of course I selected rg35xx-2024 as the primary one, it could be > another, usually the older one) > If all are happy with this approach I will resubmit a V2 with that change this evening. Regards, Ryan