From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Vinod <vkoul@kernel.org>
Cc: broonie@kernel.org, alsa-devel@alsa-project.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
bgoswami@codeaurora.org, rohitkr@codeaurora.org,
lgirdwood@gmail.com, tiwai@suse.com, devicetree@vger.kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH v2 1/5] ALSA: soc-compress: add support to snd_compr_set_runtime_buffer()
Date: Fri, 5 Oct 2018 09:16:26 +0100 [thread overview]
Message-ID: <6ac9b82e-9f92-d06a-724e-b460d24433ae@linaro.org> (raw)
In-Reply-To: <20181005003112.GG2372@vkoul-mobl>
Thanks for review!
On 05/10/18 01:31, Vinod wrote:
> On 26-09-18, 11:23, Srinivas Kandagatla wrote:
>> This patch adds support to set runtime dma buffer on compressed stream.
> The change is fine as is, but I feel we need to document the motivation
> in the changelog. The core changes need a bit more explanation on why we
> should add this..
Sure, I will add more information into the change log in next version.
--srini
>
>> Signed-off-by: Srinivas Kandagatla<srinivas.kandagatla@linaro.org>
>> ---
>> include/sound/compress_driver.h | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h
>> index ea8c93bbb0e0..0cdc3999ecfa 100644
>> --- a/include/sound/compress_driver.h
>> +++ b/include/sound/compress_driver.h
>> @@ -23,6 +23,7 @@ struct snd_compr_ops;
>> * struct snd_compr_runtime: runtime stream description
>> * @state: stream state
>> * @ops: pointer to DSP callbacks
next prev parent reply other threads:[~2018-10-05 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 10:23 [PATCH v2 0/5] ASoC: qdsp6: add compress offload support Srinivas Kandagatla
2018-09-26 10:23 ` [PATCH v2 1/5] ALSA: soc-compress: add support to snd_compr_set_runtime_buffer() Srinivas Kandagatla
2018-10-05 0:31 ` Vinod
2018-10-05 8:16 ` Srinivas Kandagatla [this message]
2018-09-26 10:23 ` [PATCH v2 2/5] ALSA: compress: make use of runtime buffer for copy Srinivas Kandagatla
2018-09-26 10:23 ` [PATCH v2 3/5] ASoC: q6asm-dai: dt-bindings: Add support to compress dais Srinivas Kandagatla
2018-09-26 10:23 ` [PATCH v2 4/5] ASoC: qdsp6: q6asm: add support to MP3 format Srinivas Kandagatla
2018-09-26 10:23 ` [PATCH v2 5/5] ASoC: qdsp6: q6asm-dai: Add support to compress offload Srinivas Kandagatla
2018-10-05 0:39 ` Vinod
2018-10-05 8:15 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac9b82e-9f92-d06a-724e-b460d24433ae@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox