From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ben Dooks <ben.dooks@sifive.com>, linux-pwm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
u.kleine-koenig@pengutronix.de,
Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greentime Hu <greentime.hu@sifive.com>,
Jude Onyenegecha <jude.onyenegecha@sifive.com>,
Sudip Mukherjee <sudip.mukherjee@sifive.com>,
William Salmon <william.salmon@sifive.com>,
Adnan Chowdhury <adnan.chowdhury@sifive.com>
Subject: Re: [PATCH 3/7] pwm: dwc: add of/platform support
Date: Wed, 13 Jul 2022 11:26:20 +0200 [thread overview]
Message-ID: <6acbebb6-177c-c5b5-f9e8-a374b9276fc1@linaro.org> (raw)
In-Reply-To: <3a1eea1f-b598-58ad-60a6-c76b77cb08c4@sifive.com>
On 13/07/2022 11:21, Ben Dooks wrote:
> On 12/07/2022 11:08, Krzysztof Kozlowski wrote:
>> On 12/07/2022 12:01, Ben Dooks wrote:
>>> The dwc pwm controller can be used in non-PCI systems, so allow
>>> either platform or OF based probing.
>>>
>>> Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
>>> ---
>>> .../devicetree/bindings/pwm/pwm-synposys.yaml | 40 ++++++++++++++
>>
>> Bindings must be a separate patch. Preferably first in the series. Use
>> proper subject prefix matching the subsystem.
>>
>> Best regards,
>> Krzysztof
>
> Thanks, seems counter-intuitive that one change is split up like that.
Why? Bindings are not really related to driver implementation, they are
shared with other projects. Binding reviewers usually care less about
implementation, so combining it with drivers forces me to read carefully
each one of 300 emails I receive...
Anyway, that's the policy since years, so nothing new here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-13 9:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 10:01 update synopsys driver for platform/devicetree support Ben Dooks
2022-07-12 10:01 ` [PATCH 1/7] pwm: change &pci->dev to dev in probe Ben Dooks
2022-07-13 8:16 ` Uwe Kleine-König
2022-07-13 10:54 ` Ben Dooks
2022-07-18 7:19 ` Ben Dooks
2022-07-18 7:49 ` Uwe Kleine-König
2022-07-18 7:54 ` Uwe Kleine-König
2022-07-12 10:01 ` [PATCH 2/7] pwm: move dwc memory alloc to own function Ben Dooks
2022-07-12 10:01 ` [PATCH 3/7] pwm: dwc: add of/platform support Ben Dooks
2022-07-12 10:08 ` Krzysztof Kozlowski
2022-07-13 9:21 ` Ben Dooks
2022-07-13 9:26 ` Krzysztof Kozlowski [this message]
2022-07-12 14:26 ` Rob Herring
2022-07-13 12:06 ` Ben Dooks
2022-07-12 22:17 ` Rob Herring
2022-07-13 11:56 ` Ben Dooks
2022-07-13 13:52 ` Uwe Kleine-König
2022-07-13 14:30 ` Ben Dooks
2022-07-13 15:07 ` Uwe Kleine-König
2022-07-13 16:20 ` Ben Dooks
2022-07-18 7:18 ` Ben Dooks
2022-07-12 10:01 ` [PATCH 4/7] pwm: dwc: allow driver to be built with COMPILE_TEST Ben Dooks
2022-07-12 10:01 ` [PATCH 5/7] pwm: dwc: add timer clock Ben Dooks
2022-07-13 6:10 ` Uwe Kleine-König
2022-07-12 10:01 ` [PATCH 6/7] pwm: dwc: remove the CONFIG_OF in " Ben Dooks
2022-07-12 10:09 ` Krzysztof Kozlowski
2022-07-12 10:20 ` Ben Dooks
2022-07-13 6:11 ` Uwe Kleine-König
2022-07-18 7:18 ` Ben Dooks
2022-07-13 9:31 ` Ben Dooks
2022-07-12 10:01 ` [PATCH 7/7] pwm: dwc: add snps,pwm-number to limit pwm count Ben Dooks
2022-07-12 10:09 ` Krzysztof Kozlowski
2022-07-18 20:08 ` Rob Herring
2022-07-19 8:20 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6acbebb6-177c-c5b5-f9e8-a374b9276fc1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=adnan.chowdhury@sifive.com \
--cc=ben.dooks@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=greentime.hu@sifive.com \
--cc=jude.onyenegecha@sifive.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sudip.mukherjee@sifive.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=william.salmon@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).