From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CF1C43334 for ; Wed, 13 Jul 2022 09:26:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230364AbiGMJ0c (ORCPT ); Wed, 13 Jul 2022 05:26:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234565AbiGMJ0c (ORCPT ); Wed, 13 Jul 2022 05:26:32 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 702DAF1E3E for ; Wed, 13 Jul 2022 02:26:30 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id bx13so12813125ljb.1 for ; Wed, 13 Jul 2022 02:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=OZFjfGPRJEW+XiqadcZTKJjaB0j0swaCsivThrUDMjU=; b=FCq6yuxggtQBm0dxq0c7IwcN9P1nVA62ZuMomo1VhXktJb+Sd35ROgB0YAtDZn+KAx ztIXecxk77fQfTuTU2FE7kDuGF0eFSy+kcNeFLyb9jdJeP4nQl0CvF5cvUAnIEaFu07o ZNAc59DTx9DhmY0BPQ3Vo1AWzsisEqWKB+pKkqSwM0Qpty9YI1xHXiDqG65dc375evFf uPnMKKwz0Aiz+KVRW+/lf2Ng0mF4QZj5M1kkTyZXZtscz4ASABAJ2efqmhG1/VCcCAnm k+GOHSmkv5sVHk80Lrg7GD4GEs1b3dGa0uMQe5KEJ0pjKYC7j/mPNhbvo4NwQZgKwvzv 1Gkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OZFjfGPRJEW+XiqadcZTKJjaB0j0swaCsivThrUDMjU=; b=hR9/bGIUOzQLn2FCaoIdpR6i66B8bOstJuIStaZU42bf89g2GRIROEzHyu5Si1V3Bt C9sc293Y6s8zpvv4mdaansWeK3WsFCSKAagZeiexjHn3x0joaixqYVQduZ1Uw3ZQoSGj L1TzXHXQy/cBBPTFk/ls0HmvvZ4m81+gi9z5D8DhxAnahMpe4kiLHOOwJSK90ddmfKTy 1mopblcmrf29a327Xs470ocE8hUSv8cVfAbMulevXf1EA0YYZ1Lpjgqu2jTdciJrMNWp 5AuHmdMtfi2CbwDRwRFPbfmdwCkN6p4Ph4+JhekZkI0haqQgc2pxbMMFf7UItzzKlguC bupA== X-Gm-Message-State: AJIora9GDMPWUqgqTnTj3sRWJD17lXMrN2VTSlfQuj5RBrrDXYPj0tJD QQ+JtqoYaxe/ChgnjMsAeLTQ/w== X-Google-Smtp-Source: AGRyM1sQ+DurMXduxwN29r9TeaVTPcZRiz0hdxAFf3tJqkALw+WRbPHct7ZSENDmwyDn5R8afxflAg== X-Received: by 2002:a05:651c:1a1f:b0:25d:4517:faf with SMTP id by31-20020a05651c1a1f00b0025d45170fafmr1166257ljb.415.1657704388771; Wed, 13 Jul 2022 02:26:28 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id v6-20020a2ea606000000b0025a672e97a6sm3033273ljp.80.2022.07.13.02.26.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 02:26:27 -0700 (PDT) Message-ID: <6acbebb6-177c-c5b5-f9e8-a374b9276fc1@linaro.org> Date: Wed, 13 Jul 2022 11:26:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/7] pwm: dwc: add of/platform support Content-Language: en-US To: Ben Dooks , linux-pwm@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , u.kleine-koenig@pengutronix.de, Thierry Reding , Krzysztof Kozlowski , Greentime Hu , Jude Onyenegecha , Sudip Mukherjee , William Salmon , Adnan Chowdhury References: <20220712100113.569042-1-ben.dooks@sifive.com> <20220712100113.569042-4-ben.dooks@sifive.com> <3a1eea1f-b598-58ad-60a6-c76b77cb08c4@sifive.com> From: Krzysztof Kozlowski In-Reply-To: <3a1eea1f-b598-58ad-60a6-c76b77cb08c4@sifive.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/07/2022 11:21, Ben Dooks wrote: > On 12/07/2022 11:08, Krzysztof Kozlowski wrote: >> On 12/07/2022 12:01, Ben Dooks wrote: >>> The dwc pwm controller can be used in non-PCI systems, so allow >>> either platform or OF based probing. >>> >>> Signed-off-by: Ben Dooks >>> --- >>> .../devicetree/bindings/pwm/pwm-synposys.yaml | 40 ++++++++++++++ >> >> Bindings must be a separate patch. Preferably first in the series. Use >> proper subject prefix matching the subsystem. >> >> Best regards, >> Krzysztof > > Thanks, seems counter-intuitive that one change is split up like that. Why? Bindings are not really related to driver implementation, they are shared with other projects. Binding reviewers usually care less about implementation, so combining it with drivers forces me to read carefully each one of 300 emails I receive... Anyway, that's the policy since years, so nothing new here. Best regards, Krzysztof